languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-06 00:59:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use Context.separator in nnbd i13n output; Fixes #38574

Browse source 
Change-Id: If125bc6d8bc9ae66d949c712921b6ce7da428f6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118890
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
This commit is contained in:
Sam Rawlins 2019-09-26 17:24:12 +00:00 committed by commit-bot@chromium.org
parent 38a3a6b6cb
commit 661816ea06
2 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/analysis_server/lib/src/edit/fix/non_nullable_fix.dart
View file

@ -225,7 +225,7 @@ analyzer:
// likely with actual directories, which need to be individually created.
var relativePath = pathContext
.relative(libraryPath, from: includedRoot)
.replaceAll('/', '__');
.replaceAll(pathContext.separator, '__');
File output = folder.getChildAssumingFile(relativePath);
String rendered = InstrumentationRenderer(info).render();
output.writeAsStringSync(rendered);

5
pkg/analysis_server/test/domain_edit_dartfix_test.dart
View file

@ -300,10 +300,7 @@ void test() {
await performFix(
includedFixes: ['non-nullable'], outputDir: outputDir.path);
expect(outputDir.exists, true);
// TODO(https://github.com/dart-lang/sdk/issues/38574): Fix Windows.
if (path.style != path.Style.windows) {
expect(outputDir.getChildren(), isNotEmpty);
}
expect(outputDir.getChildren(), isNotEmpty);
}
test_dartfix_partFile() async {