languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-28 22:52:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

[infra] Add clang-format to PRESUBMIT.py

Browse source 
Change-Id: I429c168d363f309f6338f0baf3d9b1e5bae2f86a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363641
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
This commit is contained in:
Alexander Thomas 2024-04-19 15:45:16 +00:00 committed by Commit Queue
parent 828e6032b3
commit 64a2407ca7
1 changed files with 52 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

52
PRESUBMIT.py
View file

@ -329,6 +329,57 @@ def _CheckClangTidy(input_api, output_api):
]
def _CheckClangFormat(input_api, output_api):
"""Run clang-format on VM changes."""
# Only run clang-format on linux x64.
if platform.system() != 'Linux' or platform.machine() != 'x86_64':
return []
# Run only for modified .cc or .h files, except for DEPS changes.
files = []
is_deps = False
for f in input_api.AffectedFiles():
path = f.LocalPath()
if path == 'DEPS' and any(
map(lambda content: 'clang' in content[1],
f.ChangedContents())):
is_deps = True
break
if is_cpp_file(path) and os.path.isfile(path):
files.append(path)
if is_deps:
find_args = [
'find',
'runtime/',
'-iname',
'*.h',
'-o',
'-iname',
'*.cc',
]
files = subprocess.check_output(find_args, text=True).split()
if not files:
return []
args = [
'buildtools/linux-x64/clang/bin/clang-format',
'--dry-run',
'--Werror',
]
args.extend(files)
stdout = input_api.subprocess.check_output(args).strip()
if not stdout:
return []
return [
output_api.PresubmitError('The `clang-format` revealed issues:',
long_text=stdout)
]
def _CheckAnalyzerFiles(input_api, output_api):
"""Run analyzer checks on source files."""
@ -469,6 +520,7 @@ def _CommonChecks(input_api, output_api):
results.extend(_CheckStatusFiles(input_api, output_api))
results.extend(_CheckLayering(input_api, output_api))
results.extend(_CheckClangTidy(input_api, output_api))
results.extend(_CheckClangFormat(input_api, output_api))
results.extend(_CheckTestMatrixValid(input_api, output_api))
results.extend(
input_api.canned_checks.CheckPatchFormatted(input_api, output_api))