languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 02:17:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

make SharedOptionsOptionsMap private

Browse source 
Change-Id: I21bf7f48af568626ded1aa0b885c02b92c514a9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/350344
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
This commit is contained in:
pq 2024-02-05 22:08:31 +00:00 committed by Commit Queue
parent 9008b2575d
commit 624a7b742c
1 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
pkg/analyzer/lib/src/dart/analysis/analysis_options_map.dart
View file

@ -17,6 +17,12 @@ class AnalysisOptionsMap {
/// Create an empty [AnalysisOptionsMap] instance.
AnalysisOptionsMap();
/// Create an [AnalysisOptionsMap] that holds one set of [sharedOptions] for
/// all associated files.
factory AnalysisOptionsMap.forSharedOptions(
AnalysisOptionsImpl sharedOptions) =>
_SharedOptionsOptionsMap(sharedOptions);
/// Get the first options entry or the default options object if there is none.
AnalysisOptionsImpl get firstOrDefault =>
entries.firstOrNull?.options ?? _defaultOptions;
@ -29,7 +35,8 @@ class AnalysisOptionsMap {
}
/// Get the [AnalysisOptions] instance for the given [file] (or a shared empty
/// default options object if there is no entry in [entries] for a containing folder).
/// default options object if there is no entry in [entries] for a containing
/// folder).
AnalysisOptionsImpl getOptions(File file) {
for (var entry in entries) {
if (entry.folder.contains(file.path)) return entry.options;
@ -37,13 +44,6 @@ class AnalysisOptionsMap {
return _defaultOptions;
}
/// Create an [AnalysisOptionsMap] that holds one set of [sharedOptions] for all
/// associated files.
// TODO(pq): replace w/ a factory constructor when SharedOptionsOptionsMap is made private
static SharedOptionsOptionsMap forSharedOptions(
AnalysisOptionsImpl sharedOptions) =>
SharedOptionsOptionsMap(sharedOptions);
}
/// Instances of [OptionsMapEntry] associate [Folder]s with their
@ -59,10 +59,10 @@ class OptionsMapEntry {
OptionsMapEntry(this.folder, this.options);
}
// TODO(pq): make private when no longer referenced.
class SharedOptionsOptionsMap extends AnalysisOptionsMap {
/// An option map that contains only one shared set of options.
class _SharedOptionsOptionsMap extends AnalysisOptionsMap {
final AnalysisOptionsImpl sharedOptions;
SharedOptionsOptionsMap(this.sharedOptions) {
_SharedOptionsOptionsMap(this.sharedOptions) {
var optionsFile = sharedOptions.file;
// If there's an associated file, create an entry so that we can display it
// in the diagnostics page.