[ VM / Service ] Remove bool return value for service RPC handlers

Browse source

Returning 'false' from a RPC handler in service.cc results in the VM
shutting down due to an UNIMPLEMENTED error. Since we always return
'true', even in the case of RPC errors, and the TODO to handle 'false'
returns is over 6 years old, RPC handlers should just have a void
return.

Example: invoking getSourceReport on an AOT VM should just return a RPC
error, but 'false' was being returned from GetSourceReport causing the
VM to shutdown.

Fixes https://github.com/flutter/devtools/issues/2955.

TEST=Existing service tests

Change-Id: I344c2f4cf849d27f08f59e8c61fb4c17c32719d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197241
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>

...

This commit is contained in:

Ben Konyi 2021-04-30 00:22:55 +00:00 committed by commit-bot@chromium.org

parent 8488b37aae

commit 60d149d835

1 changed files with 215 additions and 326 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show stats Download patch file Download diff file Expand all files Collapse all files

541

runtime/vm/service.cc

View file

File diff suppressed because it is too large Load diff