languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 12:58:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup method signatures that were incorrect due to a lack of understanding about how Dart generics work.

Browse source 
BUG=
R=alanknight@google.com, terry@google.com

Review URL: https://codereview.chromium.org//896293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43562 260f80e4-7a28-3924-810f-c04153c831b5
This commit is contained in:
jacobr@google.com 2015-02-06 19:15:49 +00:00
parent 172b8bee6e
commit 60bae5bb5d
8 changed files with 26 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
sdk/lib/html/dart2js/html_dart2js.dart
View file

@ -8277,7 +8277,7 @@ class Document extends Node
* For details about CSS selector syntax, see the
* [CSS selector specification](http://www.w3.org/TR/css3-selectors/).
*/
ElementList querySelectorAll(String selectors) {
ElementList<Element> querySelectorAll(String selectors) {
return new _FrozenElementList._wrap(_querySelectorAll(selectors));
}
@ -8297,7 +8297,7 @@ class Document extends Node
@deprecated
@Experimental()
@DomName('Document.querySelectorAll')
ElementList queryAll(String relativeSelectors) =>
ElementList<Element> queryAll(String relativeSelectors) =>
querySelectorAll(relativeSelectors);
/// Checks if [registerElement] is supported on the current platform.
@ -8384,7 +8384,7 @@ class DocumentFragment extends Node implements ParentNode {
* For details about CSS selector syntax, see the
* [CSS selector specification](http://www.w3.org/TR/css3-selectors/).
*/
ElementList querySelectorAll(String selectors) =>
ElementList<Element> querySelectorAll(String selectors) =>
new _FrozenElementList._wrap(_querySelectorAll(selectors));
@ -8442,7 +8442,7 @@ class DocumentFragment extends Node implements ParentNode {
@deprecated
@Experimental()
@DomName('DocumentFragment.querySelectorAll')
ElementList queryAll(String relativeSelectors) {
ElementList<Element> queryAll(String relativeSelectors) {
return querySelectorAll(relativeSelectors);
}
// To suppress missing implicit constructor warnings.
@ -10878,7 +10878,7 @@ abstract class Element extends Node implements GlobalEventHandlers, ParentNode,
* [CSS selector specification](http://www.w3.org/TR/css3-selectors/).
*/
@DomName('Element.querySelectorAll')
ElementList querySelectorAll(String selectors) =>
ElementList<Element> querySelectorAll(String selectors) =>
new _FrozenElementList._wrap(_querySelectorAll(selectors));
/**
@ -10897,7 +10897,7 @@ abstract class Element extends Node implements GlobalEventHandlers, ParentNode,
@deprecated
@DomName('Element.querySelectorAll')
@Experimental()
ElementList queryAll(String relativeSelectors) =>
ElementList<Element> queryAll(String relativeSelectors) =>
querySelectorAll(relativeSelectors);
/**
@ -38498,7 +38498,7 @@ Element query(String relativeSelectors) => document.query(relativeSelectors);
*/
@deprecated
@Experimental()
ElementList queryAll(String relativeSelectors) => document.queryAll(relativeSelectors);
ElementList<Element> queryAll(String relativeSelectors) => document.queryAll(relativeSelectors);
/**
* Finds the first descendant element of this document that matches the
@ -38535,7 +38535,7 @@ Element querySelector(String selectors) => document.querySelector(selectors);
* For details about CSS selector syntax, see the
* [CSS selector specification](http://www.w3.org/TR/css3-selectors/).
*/
ElementList querySelectorAll(String selectors) => document.querySelectorAll(selectors);
ElementList<Element> querySelectorAll(String selectors) => document.querySelectorAll(selectors);
/// A utility for changing the Dart wrapper type for elements.
abstract class ElementUpgrader {

16
sdk/lib/html/dartium/html_dartium.dart
View file

@ -9205,7 +9205,7 @@ class Document extends Node
* For details about CSS selector syntax, see the
* [CSS selector specification](http://www.w3.org/TR/css3-selectors/).
*/
ElementList querySelectorAll(String selectors) {
ElementList<Element> querySelectorAll(String selectors) {
return new _FrozenElementList._wrap(_querySelectorAll(selectors));
}
@ -9225,7 +9225,7 @@ class Document extends Node
@deprecated
@Experimental()
@DomName('Document.querySelectorAll')
ElementList queryAll(String relativeSelectors) =>
ElementList<Element> queryAll(String relativeSelectors) =>
querySelectorAll(relativeSelectors);
/// Checks if [registerElement] is supported on the current platform.
@ -9302,7 +9302,7 @@ class DocumentFragment extends Node implements ParentNode {
* For details about CSS selector syntax, see the
* [CSS selector specification](http://www.w3.org/TR/css3-selectors/).
*/
ElementList querySelectorAll(String selectors) =>
ElementList<Element> querySelectorAll(String selectors) =>
new _FrozenElementList._wrap(_querySelectorAll(selectors));
@ -9360,7 +9360,7 @@ class DocumentFragment extends Node implements ParentNode {
@deprecated
@Experimental()
@DomName('DocumentFragment.querySelectorAll')
ElementList queryAll(String relativeSelectors) {
ElementList<Element> queryAll(String relativeSelectors) {
return querySelectorAll(relativeSelectors);
}
// To suppress missing implicit constructor warnings.
@ -11900,7 +11900,7 @@ abstract class Element extends Node implements GlobalEventHandlers, ParentNode,
* [CSS selector specification](http://www.w3.org/TR/css3-selectors/).
*/
@DomName('Element.querySelectorAll')
ElementList querySelectorAll(String selectors) =>
ElementList<Element> querySelectorAll(String selectors) =>
new _FrozenElementList._wrap(_querySelectorAll(selectors));
/**
@ -11919,7 +11919,7 @@ abstract class Element extends Node implements GlobalEventHandlers, ParentNode,
@deprecated
@DomName('Element.querySelectorAll')
@Experimental()
ElementList queryAll(String relativeSelectors) =>
ElementList<Element> queryAll(String relativeSelectors) =>
querySelectorAll(relativeSelectors);
/**
@ -40813,7 +40813,7 @@ Element query(String relativeSelectors) => document.query(relativeSelectors);
*/
@deprecated
@Experimental()
ElementList queryAll(String relativeSelectors) => document.queryAll(relativeSelectors);
ElementList<Element> queryAll(String relativeSelectors) => document.queryAll(relativeSelectors);
/**
* Finds the first descendant element of this document that matches the
@ -40850,7 +40850,7 @@ Element querySelector(String selectors) => document.querySelector(selectors);
* For details about CSS selector syntax, see the
* [CSS selector specification](http://www.w3.org/TR/css3-selectors/).
*/
ElementList querySelectorAll(String selectors) => document.querySelectorAll(selectors);
ElementList<Element> querySelectorAll(String selectors) => document.querySelectorAll(selectors);
/// A utility for changing the Dart wrapper type for elements.
abstract class ElementUpgrader {

2
tests/html/element_classes_test.dart
View file

@ -198,7 +198,7 @@ main() {
Element listElement;
ElementList listElementSetup() {
ElementList<Element> listElementSetup() {
listElement = makeListElement();
document.documentElement.children.add(listElement);
return document.queryAll('li');

2
tests/html/element_test.dart
View file

@ -915,7 +915,7 @@ main() {
// some of these tests simply check that a method can be called.
// 2. Some methods are implemented by mixins.
ElementList makeElementList() =>
ElementList<Element> makeElementList() =>
(new Element.html("<div>Foo<br/><!--baz--><br/><br/></div>"))
.queryAll('br');

4
tools/dom/src/shared_html.dart
View file

@ -30,7 +30,7 @@ Element query(String relativeSelectors) => document.query(relativeSelectors);
*/
@deprecated
@Experimental()
ElementList queryAll(String relativeSelectors) => document.queryAll(relativeSelectors);
ElementList<Element> queryAll(String relativeSelectors) => document.queryAll(relativeSelectors);
/**
* Finds the first descendant element of this document that matches the
@ -67,7 +67,7 @@ Element querySelector(String selectors) => document.querySelector(selectors);
* For details about CSS selector syntax, see the
* [CSS selector specification](http://www.w3.org/TR/css3-selectors/).
*/
ElementList querySelectorAll(String selectors) => document.querySelectorAll(selectors);
ElementList<Element> querySelectorAll(String selectors) => document.querySelectorAll(selectors);
/// A utility for changing the Dart wrapper type for elements.
abstract class ElementUpgrader {

4
tools/dom/templates/html/impl/impl_Document.darttemplate
View file

@ -25,7 +25,7 @@ $!MEMBERS
* For details about CSS selector syntax, see the
* [CSS selector specification](http://www.w3.org/TR/css3-selectors/).
*/
ElementList querySelectorAll(String selectors) {
ElementList<Element> querySelectorAll(String selectors) {
return new _FrozenElementList._wrap(_querySelectorAll(selectors));
}
@ -45,7 +45,7 @@ $!MEMBERS
@deprecated
@Experimental()
@DomName('Document.querySelectorAll')
ElementList queryAll(String relativeSelectors) =>
ElementList<Element> queryAll(String relativeSelectors) =>
querySelectorAll(relativeSelectors);
/// Checks if [registerElement] is supported on the current platform.

4
tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate
View file

@ -57,7 +57,7 @@ $endif
* For details about CSS selector syntax, see the
* [CSS selector specification](http://www.w3.org/TR/css3-selectors/).
*/
ElementList querySelectorAll(String selectors) =>
ElementList<Element> querySelectorAll(String selectors) =>
new _FrozenElementList._wrap(_querySelectorAll(selectors));
@ -115,7 +115,7 @@ $endif
@deprecated
@Experimental()
@DomName('DocumentFragment.querySelectorAll')
ElementList queryAll(String relativeSelectors) {
ElementList<Element> queryAll(String relativeSelectors) {
return querySelectorAll(relativeSelectors);
}
$!MEMBERS

4
tools/dom/templates/html/impl/impl_Element.darttemplate
View file

@ -594,7 +594,7 @@ $(ANNOTATIONS)$(NATIVESPEC)abstract class $CLASSNAME$EXTENDS$IMPLEMENTS {
* [CSS selector specification](http://www.w3.org/TR/css3-selectors/).
*/
@DomName('Element.querySelectorAll')
ElementList querySelectorAll(String selectors) =>
ElementList<Element> querySelectorAll(String selectors) =>
new _FrozenElementList._wrap(_querySelectorAll(selectors));
/**
@ -613,7 +613,7 @@ $(ANNOTATIONS)$(NATIVESPEC)abstract class $CLASSNAME$EXTENDS$IMPLEMENTS {
@deprecated
@DomName('Element.querySelectorAll')
@Experimental()
ElementList queryAll(String relativeSelectors) =>
ElementList<Element> queryAll(String relativeSelectors) =>
querySelectorAll(relativeSelectors);
/**