languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 16:41:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

[VM] Add $target_gen_dir/gen_kernel_bytecode.dill.d to outputs of GN action, to ensure directory is created before action is run

Browse source 
This fixes flaky build failures on our bots.

To reproduce the original issue:
  % rm -rf out/DebugX64
  % tools/build.py -mdebug -ax64 gen_kernel_bytecode_dill
  output: Error: Unable to open snapshot depfile: .../out/DebugX64/gen/runtime/bin/gen_kernel_bytecode.dill.d

This change seems to force GN to create the parent directory of outputs before
running the action.

Change-Id: Ia388f423d7724516bc6f00cd39bed19533587f39
Reviewed-on: https://dart-review.googlesource.com/c/79202
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
This commit is contained in:
Martin Kustermann 2018-10-11 09:44:12 +00:00
parent 49d7fb39ac
commit 5c9a8d8cb5
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
runtime/bin/BUILD.gn
View file

@ -826,13 +826,14 @@ prebuilt_dart_action("gen_kernel_bytecode_dill") {
platform_dill = "$root_out_dir/vm_platform_strong.dill"
output = "$root_out_dir/gen_kernel_bytecode.dill"
depfile = "$target_gen_dir/gen_kernel_bytecode.dill.d"
outputs = [
output,
depfile,
]
script = "../../pkg/vm/bin/gen_kernel.dart"
depfile = "$target_gen_dir/gen_kernel_bytecode.dill.d"
abs_depfile = rebase_path(depfile)
rebased_output = rebase_path(output, root_out_dir)
vm_args = [