languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 12:24:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

[CFE] Skip failing flutter test on bot flutter-frontend

Browse source 
Skip test that fails to compile because theres an error triggered by
constant evaluation because we're not compiling for a web-platform.
This should turn the bot green.

Change-Id: Icb7a4d5a55f14c146f03e17d06d518f615189e27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115205
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
This commit is contained in:
Jens Johansen 2019-09-02 10:38:16 +00:00 committed by commit-bot@chromium.org
parent b6880f76b0
commit 5bf51b4c25
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
pkg/vm/test/frontend_server_flutter.dart
View file

@ -90,9 +90,19 @@ void attemptStuff(Directory tempDir, Directory flutterPlatformDirectory,
// '--unsafe-package-serialization',
];
bool shouldSkip(File f) {
// TODO(jensj): Come up with a better way to (temporarily) skip some tests.
List<String> pathSegments = f.uri.pathSegments;
if (pathSegments.sublist(pathSegments.length - 5).join("/") ==
"packages/flutter/test/widgets/html_element_view_test.dart") {
return true;
}
return false;
}
List<File> testFiles = new List<File>.from(testDir
.listSync(recursive: true)
.where((f) => f.path.endsWith("_test.dart")));
.where((f) => f.path.endsWith("_test.dart") && !shouldSkip(f)));
if (testFiles.isEmpty) return;
Stopwatch stopwatch = new Stopwatch()..start();