languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-01 19:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Set a longer default timeout for dartdev.dart tests so flakiness is removed from the bots. Reason in utils.dart:

Browse source 
/// A long [Timeout] is provided for tests that start a process on
/// `bin/dartdev.dart` as the command is not compiled ahead of time, and each
/// invocation requires the VM to compile the entire dependency graph.

Change-Id: Ieec2238b5fb7358af5e9924912eaf2580d5dbfb1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143181
Commit-Queue: Siva Annamalai <asiva@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
This commit is contained in:
Jaime Wren 2020-04-14 04:19:29 +00:00 committed by commit-bot@chromium.org
parent 4aa896464a
commit 5bf1223ea9
10 changed files with 14 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/dartdev/test/commands/analyze_test.dart
View file

@ -7,7 +7,7 @@ import 'package:test/test.dart';
import '../utils.dart';
void main() {
group('analyze', defineAnalyze, timeout: defaultTimeout);
group('analyze', defineAnalyze, timeout: longTimeout);
}
const String _analyzeDescriptionText = "Analyze the project's Dart code.";

2
pkg/dartdev/test/commands/create_test.dart
View file

@ -12,7 +12,7 @@ import 'package:test/test.dart';
import '../utils.dart';
void main() {
group('create', defineCreateTests);
group('create', defineCreateTests, timeout: longTimeout);
}
void defineCreateTests() {

4
pkg/dartdev/test/commands/flag_test.dart
View file

@ -9,8 +9,8 @@ import 'package:test/test.dart';
import '../utils.dart';
void main() {
group('command', command);
group('flag', help);
group('command', command, timeout: longTimeout);
group('flag', help, timeout: longTimeout);
}
void command() {

2
pkg/dartdev/test/commands/format_test.dart
View file

@ -9,7 +9,7 @@ import 'package:test/test.dart';
import '../utils.dart';
void main() {
group('format', format);
group('format', format, timeout: longTimeout);
}
void format() {

2
pkg/dartdev/test/commands/help_test.dart
View file

@ -9,7 +9,7 @@ import 'package:test/test.dart';
import '../utils.dart';
void main() {
group('help', help);
group('help', help, timeout: longTimeout);
}
void help() {

2
pkg/dartdev/test/commands/migrate_test.dart
View file

@ -8,7 +8,7 @@ import 'package:test/test.dart';
import '../utils.dart';
void main() {
group('migrate', defineMigrateTests);
group('migrate', defineMigrateTests, timeout: longTimeout);
}
// TODO(jcollins-g): Set to true and/or remove when when NNBD is enabled in the

2
pkg/dartdev/test/commands/pub_test.dart
View file

@ -7,7 +7,7 @@ import 'package:test/test.dart';
import '../utils.dart';
void main() {
group('pub', pub);
group('pub', pub, timeout: longTimeout);
}
void pub() {

2
pkg/dartdev/test/commands/run_test.dart
View file

@ -9,7 +9,7 @@ import 'package:test/test.dart';
import '../utils.dart';
void main() {
group('run', run);
group('run', run, timeout: longTimeout);
}
void run() {

2
pkg/dartdev/test/commands/test_test.dart
View file

@ -7,7 +7,7 @@ import 'package:test/test.dart';
import '../utils.dart';
void main() {
group('test', defineTest);
group('test', defineTest, timeout: longTimeout);
}
void defineTest() {

5
pkg/dartdev/test/utils.dart
View file

@ -7,7 +7,10 @@ import 'dart:io';
import 'package:path/path.dart' as path;
import 'package:test/test.dart';
Timeout defaultTimeout = Timeout(Duration(seconds: 15));
/// A long [Timeout] is provided for tests that start a process on
/// `bin/dartdev.dart` as the command is not compiled ahead of time, and each
/// invocation requires the VM to compile the entire dependency graph.
const Timeout longTimeout = Timeout(Duration(minutes: 5));
TestProject project({String mainSrc, String analysisOptions}) {
return TestProject(mainSrc: mainSrc, analysisOptions: analysisOptions);