languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-04 16:44:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ddc] Add getter to accompany setter from mixin

Browse source 
When a mixin introduces a forwarding stub setter in the class
hierarchy there also needs to be the accompanying getter in the same
class if a getter is present further up the class hierarchy. This
is because the setter is represented as a property with only a setter
and the lack of a getter will not cause a lookup further up the
prototype chain.

Fixes: https://github.com/dart-lang/sdk/issues/46867
Change-Id: I8e41eb9d2569f0819200a82367ab7c723a1011cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209854
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
This commit is contained in:
Nicholas Shahan 2021-08-17 18:26:02 +00:00 committed by commit-bot@chromium.org
parent a899525bdc
commit 5b3cadc7e6
1 changed files with 21 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
pkg/dev_compiler/lib/src/kernel/compiler.dart
View file

@ -1127,13 +1127,29 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
var mixinName =
getLocalClassName(superclass) + '_' + getLocalClassName(mixinClass);
var mixinId = _emitTemporaryId(mixinName + '\$');
// Collect all forwarding stubs from anonymous mixins classes. These will
// contain covariant parameter checks that need to be applied.
var forwardingMethodStubs = [
// Collect all forwarding stub setters from anonymous mixins classes.
// These will contain covariant parameter checks that need to be applied.
var savedClassProperties = _classProperties;
_classProperties =
ClassPropertyModel.build(_types, _extensionTypes, _virtualFields, m);
var forwardingSetters = {
for (var procedure in m.procedures)
if (procedure.isForwardingStub && !procedure.isAbstract)
_emitMethodDeclaration(procedure)
];
procedure.name.text: procedure
};
var forwardingMethodStubs = <js_ast.Method>[];
for (var s in forwardingSetters.values) {
forwardingMethodStubs.add(_emitMethodDeclaration(s));
// If there are getters matching the setters somewhere above in the
// class hierarchy we must also generate a forwarding getter due to the
// representation used in the compiled JavaScript.
var getterWrapper = _emitSuperAccessorWrapper(s, {}, forwardingSetters);
if (getterWrapper != null) forwardingMethodStubs.add(getterWrapper);
}
_classProperties = savedClassProperties;
// Bind the mixin class to a name to workaround a V8 bug with es6 classes
// and anonymous function names.