languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-02 23:59:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Properly handle Windows file: URLs on Node.js (#30098)

Browse source 
This adds logic to the JS implementation of URI to determine whether
the code is running on Windows under Node.js.
This commit is contained in:
Natalie Weizenbaum 2017-07-12 14:57:01 -07:00 committed by GitHub
parent a7865761d4
commit 5a74d8ab09
3 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
CHANGELOG.md
View file

@ -27,6 +27,10 @@
the system level timeout duration, a timeout may occur sooner than specified
in 'timeout'.
* `dart:core`
* The `Uri` class now correctly handles paths while running on Node.js on
Windows.
### Dart VM
* Support for MIPS has been remvoed.

8
pkg/dev_compiler/tool/input_sdk/patch/core_patch.dart
View file

@ -602,7 +602,13 @@ class Uri {
@patch
class _Uri {
@patch
static bool get _isWindows => false;
static bool get _isWindows => _isWindowsCached;
static final bool _isWindowsCached = JS(
'bool',
'typeof process != "undefined" && '
'Object.prototype.toString.call(process) == "[object process]" && '
'process.platform == "win32"');
// Matches a String that _uriEncodes to itself regardless of the kind of
// component. This corresponds to [_unreservedTable], i.e. characters that

8
sdk/lib/_internal/js_runtime/lib/core_patch.dart
View file

@ -611,7 +611,13 @@ class Uri {
@patch
class _Uri {
@patch
static bool get _isWindows => false;
static bool get _isWindows => _isWindowsCached;
static final bool _isWindowsCached = JS(
'bool',
'typeof process != "undefined" && '
'Object.prototype.toString.call(process) == "[object process]" && '
'process.platform == "win32"');
// Matches a String that _uriEncodes to itself regardless of the kind of
// component. This corresponds to [_unreservedTable], i.e. characters that