From 5a3b8326e4d274297def264753948f70b837e113 Mon Sep 17 00:00:00 2001 From: Bob Nystrom Date: Fri, 7 Jul 2017 16:49:44 -0700 Subject: [PATCH] Handle spaces in paths in status files. (#30107) Also triage a couple more dartdevc tests. --- tests/language_strong/language_strong.status | 3 +-- tests/lib_strong/lib_strong.status | 4 ++-- tools/testing/dart/status_file.dart | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/language_strong/language_strong.status b/tests/language_strong/language_strong.status index f14189f06a9..fbeb96345ad 100644 --- a/tests/language_strong/language_strong.status +++ b/tests/language_strong/language_strong.status @@ -746,8 +746,7 @@ const_switch_test/02: RuntimeError # Issue 29920 const_switch_test/04: RuntimeError # Ints and doubles are unified. constant_type_literal_test/01: MissingCompileTimeError # DDC allows type parameter type literals in const expressions. constructor12_test: RuntimeError # Issue 29920 -covariant_subtyping_tearoff2_test: RuntimeError # Issue 29920 -covariant_subtyping_tearoff3_test: RuntimeError # Issue 29920 +covariant_subtyping_test: RuntimeError # Issue 29920 covariant_subtyping_unsafe_call2_test: RuntimeError # Issue 29920 covariant_subtyping_unsafe_call3_test: RuntimeError # Issue 29920 custom_await_stack_trace_test: RuntimeError # Issue 29920 diff --git a/tests/lib_strong/lib_strong.status b/tests/lib_strong/lib_strong.status index 797afa1f387..299e9964b74 100644 --- a/tests/lib_strong/lib_strong.status +++ b/tests/lib_strong/lib_strong.status @@ -191,10 +191,12 @@ html/custom/created_callback_test: CompileTimeError # Issue 29922 html/custom/document_register_basic_test: CompileTimeError # Issue 29922 html/custom/document_register_type_extensions_test/construction: CompileTimeError # Issue 29922 html/custom/document_register_type_extensions_test/constructors: CompileTimeError # Issue 29922 +html/custom/document_register_type_extensions_test/createElement with type extension: CompileTimeError # Issue 29922 html/custom/document_register_type_extensions_test/functional: CompileTimeError # Issue 29922 html/custom/document_register_type_extensions_test/namespaces: CompileTimeError # Issue 29922 html/custom/document_register_type_extensions_test/parsing: CompileTimeError # Issue 29922 html/custom/document_register_type_extensions_test/registration: CompileTimeError # Issue 29922 +html/custom/document_register_type_extensions_test/single-parameter createElement: CompileTimeError # Issue 29922 html/custom/element_upgrade_test: CompileTimeError # Issue 29922 html/custom/entered_left_view_test/disconnected_subtree: CompileTimeError # Issue 29922 html/custom/entered_left_view_test/shadow_dom: CompileTimeError # Issue 29922 @@ -355,5 +357,3 @@ typed_data/int32x4_bigint_test: RuntimeError # Issue 29922 typed_data/int64_list_load_store_test: RuntimeError # Issue 29922 typed_data/typed_data_hierarchy_int64_test: RuntimeError # Issue 29922 typed_data/typed_data_list_test: RuntimeError # Issue 29922 -html/custom/document_register_type_extensions_test/single-parameter createElement: CompileTimeError # Issue 29922 -html/custom/document_register_type_extensions_test/createElement with type extension: CompileTimeError # Issue 29922 diff --git a/tools/testing/dart/status_file.dart b/tools/testing/dart/status_file.dart index e29530693ff..df64025ba03 100644 --- a/tools/testing/dart/status_file.dart +++ b/tools/testing/dart/status_file.dart @@ -18,7 +18,7 @@ final _sectionPattern = new RegExp(r"^\[(.+?)\]"); /// like: /// /// some/path/to/some_test: Pass || Fail -final _entryPattern = new RegExp(r"\s*([^: ]*)\s*:(.*)"); +final _entryPattern = new RegExp(r"^([^:#]+):(.*)"); /// Matches an issue number in a comment, like: ///