From 5963c95f47fe2d0390ff93aa9fe750d86b206de2 Mon Sep 17 00:00:00 2001 From: Martin Kustermann Date: Wed, 29 May 2024 12:48:24 +0000 Subject: [PATCH] [dart2wasm] Unskip lib/async/stream_periodic3_test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Closes https://github.com/dart-lang/sdk/issues/50901 Change-Id: If0d4cc4160fc038c93ee6d2357eb185dd42e5a17 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368564 Reviewed-by: Ömer Ağacan Commit-Queue: Martin Kustermann --- tests/lib/async/stream_periodic3_test.dart | 8 ++++---- tests/lib/lib.status | 2 -- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/lib/async/stream_periodic3_test.dart b/tests/lib/async/stream_periodic3_test.dart index a1fbbd07a7b..21436ca3974 100644 --- a/tests/lib/async/stream_periodic3_test.dart +++ b/tests/lib/async/stream_periodic3_test.dart @@ -8,12 +8,12 @@ library dart.test.stream_from_iterable; import 'dart:async'; import 'package:async_helper/async_minitest.dart'; +import 'package:expect/config.dart'; -// The stopwatch is more precise than the Timer. +// The Stopwatch is more precise than the Timer. // Some browsers (Firefox and IE so far) can trigger too early. So we add more -// margin. We use identical(1, 1.0) as an easy way to know if the test is -// compiled by dart2js. -int get safetyMargin => identical(1, 1.0) ? 5 : 0; +// margin. +int get safetyMargin => isWebConfiguration ? 5 : 0; main() { test("stream-periodic3", () { diff --git a/tests/lib/lib.status b/tests/lib/lib.status index ec2de91ca64..0390e4a319c 100644 --- a/tests/lib/lib.status +++ b/tests/lib/lib.status @@ -2,13 +2,11 @@ # for details. All rights reserved. Use of this source code is governed by a # BSD-style license that can be found in the LICENSE file. html/cross_frame_test: Skip # Issue 32039, test reloads itself (not by design - investigate) -wasm/*: Skip # dart:_wasm is currently behind a Dart SDK build flag. [ $arch == simarm ] convert/utf85_test: Skip # Pass, Slow Issue 12644. [ $compiler == dart2wasm ] -async/stream_periodic3_test: Skip # Flaky, issue 50901 fix_data_tests/*: SkipByDesign html/*: SkipByDesign # dart:html not supported on dart2wasm isolate/*: SkipByDesign