mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 00:29:48 +00:00
[vm] Weaken dwarf_stack_trace expected stack trace.
We only check the expected stack starting from the call to foo in main, so we no longer depend on what is captured in the stacktrace for how main is invoked. Also removes the old status lines for this test, which are no longer applicable, and cleans up the documentation a little. Fixes https://github.com/dart-lang/sdk/issues/39766. Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try Change-Id: I61f0465dcd55d090c49db9c6af503ae9c0df6313 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128401 Reviewed-by: Clement Skau <cskau@google.com> Commit-Queue: Teagan Strickland <sstrickl@google.com>
This commit is contained in:
parent
a577d0aea5
commit
5824d3ed53
|
@ -1,7 +1,5 @@
|
|||
# Using and interpreting DWARF stack traces
|
||||
|
||||
When using the `--dwarf-stack-traces` flag,
|
||||
|
||||
The Dart VM AOT compiler can encode code source mapping information as DWARF
|
||||
debugging information instead of using in-snapshot `CodeSourceMap` objects.
|
||||
Unlike `CodeSourceMap` objects, this DWARF information can then be stripped
|
||||
|
|
|
@ -68,12 +68,6 @@ final expectedCallsInfo = <List<CallInfo>>[
|
|||
line: 29,
|
||||
inlined: false)
|
||||
],
|
||||
// Internal frames have non-positive line numbers in the call information.
|
||||
[
|
||||
CallInfo(
|
||||
function: "main",
|
||||
filename: "dwarf_stack_trace_obfuscate_test.dart",
|
||||
line: 0,
|
||||
inlined: false),
|
||||
]
|
||||
// Don't assume anything about any of the frames below the call to foo
|
||||
// in main, as this makes the test too brittle.
|
||||
];
|
||||
|
|
|
@ -160,14 +160,8 @@ final expectedCallsInfo = <List<CallInfo>>[
|
|||
line: 30,
|
||||
inlined: false)
|
||||
],
|
||||
// Internal frames have non-positive line numbers in the call information.
|
||||
[
|
||||
CallInfo(
|
||||
function: "main",
|
||||
filename: "dwarf_stack_trace_test.dart",
|
||||
line: 0,
|
||||
inlined: false),
|
||||
]
|
||||
// Don't assume anything about any of the frames below the call to foo
|
||||
// in main, as this makes the test too brittle.
|
||||
];
|
||||
|
||||
List<List<CallInfo>> removeInternalCalls(List<List<CallInfo>> original) =>
|
||||
|
|
|
@ -66,9 +66,6 @@ io/*: Skip # Issue 30618
|
|||
[ $compiler != none && $runtime != dart_precompiled && $runtime != vm ]
|
||||
env_test: Skip # This is testing a vm command line parsing scenario.
|
||||
|
||||
[ $mode == product && $runtime == dart_precompiled ]
|
||||
dwarf_stack_trace_test: SkipByDesign # Due to instruction canonicalization we can end up having the wrong names in stack traces.
|
||||
|
||||
[ $runtime == vm && $system == linux ]
|
||||
io/http_basic_test: Slow # Issue 28046, These tests might be slow on an opt counter threshold bot. They also time out on the bot occasionally => flaky test issue 28046
|
||||
io/http_launch_test: Slow # Issue 28046, These tests might be slow on an opt counter threshold bot. They also time out on the bot occasionally => flaky test issue 28046
|
||||
|
|
|
@ -2,9 +2,6 @@
|
|||
# for details. All rights reserved. Use of this source code is governed by a
|
||||
# BSD-style license that can be found in the LICENSE file.
|
||||
|
||||
[ $builder_tag == obfuscated ]
|
||||
dwarf_stack_trace_test: Pass, RuntimeError # Issue 35563
|
||||
|
||||
[ $runtime == dart_precompiled ]
|
||||
http_launch_test: Skip
|
||||
io/addlatexhash_test: Skip
|
||||
|
@ -58,9 +55,6 @@ package/scenarios/packages_option_only/packages_option_only_test: Skip
|
|||
io/socket_cancel_connect_test: RuntimeError # Issue 34142
|
||||
io/stdout_stderr_non_blocking_test: Pass, Timeout # Issue 28426
|
||||
|
||||
[ $mode == product && $runtime == dart_precompiled ]
|
||||
dwarf_stack_trace_test: Pass, RuntimeError # Results will flake due to identical code folding
|
||||
|
||||
[ $runtime == dart_precompiled && $checked ]
|
||||
io/namespace_test: RuntimeError
|
||||
|
||||
|
|
Loading…
Reference in a new issue