languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 22:19:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change setProperty to take in nullable |value|

Browse source 
IDL allows |value| to be nullable.

Change-Id: I1db4a7929f0a83c4772e1a11384afb70ead53501
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136722
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
This commit is contained in:
Srujan Gaddam 2020-02-22 02:22:21 +00:00 committed by commit-bot@chromium.org
parent d41e419904
commit 55f4b1294e
3 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
sdk_nnbd/lib/html/dart2js/html_dart2js.dart
View file

@ -4096,7 +4096,7 @@ class CssStyleDeclaration extends Interceptor with CssStyleDeclarationBase {
return JS('bool', '# in #', propertyName, this);
}
void setProperty(String propertyName, String value, [String? priority]) {
void setProperty(String propertyName, String? value, [String? priority]) {
return _setPropertyHelper(
_browserPropertyName(propertyName), value, priority);
}
@ -5275,7 +5275,7 @@ class _CssStyleDeclarationSet extends Object with CssStyleDeclarationBase {
_elementCssStyleDeclarationSetIterable!.first
.getPropertyValue(propertyName);
void setProperty(String propertyName, String value, [String? priority]) {
void setProperty(String propertyName, String? value, [String? priority]) {
_elementCssStyleDeclarationSetIterable!
.forEach((e) => e.setProperty(propertyName, value, priority));
}
@ -5746,7 +5746,7 @@ class _CssStyleDeclarationSet extends Object with CssStyleDeclarationBase {
abstract class CssStyleDeclarationBase {
String getPropertyValue(String propertyName);
void setProperty(String propertyName, String value, [String? priority]);
void setProperty(String propertyName, String? value, [String? priority]);
/** Gets the value of "align-content" */
String get alignContent => getPropertyValue('align-content');

6
tools/dom/scripts/css_code_generator.py
View file

@ -150,7 +150,7 @@ $(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME $EXTENDS with
}
void setProperty(String propertyName, String value,
void setProperty(String propertyName, String$NULLABLE value,
[String$NULLABLE priority]) {
return _setPropertyHelper(_browserPropertyName(propertyName),
value, priority);
@ -240,7 +240,7 @@ class _CssStyleDeclarationSet extends Object with CssStyleDeclarationBase {
_elementCssStyleDeclarationSetIterable$NULLASSERT.first.getPropertyValue(
propertyName);
void setProperty(String propertyName, String value,
void setProperty(String propertyName, String$NULLABLE value,
[String$NULLABLE priority]) {
_elementCssStyleDeclarationSetIterable$NULLASSERT.forEach((e) =>
e.setProperty(propertyName, value, priority));
@ -277,7 +277,7 @@ class _CssStyleDeclarationSet extends Object with CssStyleDeclarationBase {
abstract class CssStyleDeclarationBase {
String getPropertyValue(String propertyName);
void setProperty(String propertyName, String value,
void setProperty(String propertyName, String$NULLABLE value,
[String$NULLABLE priority]);
""")

6
tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate
View file

@ -52,7 +52,7 @@ $(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME $EXTENDS with
}
void setProperty(String propertyName, String value,
void setProperty(String propertyName, String$NULLABLE value,
[String$NULLABLE priority]) {
return _setPropertyHelper(_browserPropertyName(propertyName),
value, priority);
@ -1114,7 +1114,7 @@ class _CssStyleDeclarationSet extends Object with CssStyleDeclarationBase {
_elementCssStyleDeclarationSetIterable$NULLASSERT.first.getPropertyValue(
propertyName);
void setProperty(String propertyName, String value,
void setProperty(String propertyName, String$NULLABLE value,
[String$NULLABLE priority]) {
_elementCssStyleDeclarationSetIterable$NULLASSERT.forEach((e) =>
e.setProperty(propertyName, value, priority));
@ -1588,7 +1588,7 @@ class _CssStyleDeclarationSet extends Object with CssStyleDeclarationBase {
abstract class CssStyleDeclarationBase {
String getPropertyValue(String propertyName);
void setProperty(String propertyName, String value,
void setProperty(String propertyName, String$NULLABLE value,
[String$NULLABLE priority]);
/** Gets the value of "align-content" */