mirror of
https://github.com/dart-lang/sdk
synced 2024-09-06 00:59:09 +00:00
Add canned_checks.CheckPatchFormatted to presubmit
This will include checks for python file formatting thanks to the presence of the `.style.yapf` file at the root of the repo. - Refactor to a `_CommonChecks` to reduce duplication and use `results.extend` so that each check is defined on its own line. - Add the `canned_checks.CheckPatchFormatted` check. See discussion at https://dart-review.googlesource.com/c/sdk/+/111600 Change-Id: I089112c309bf6b9a518c85fa6b66200b75519e33 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116364 Reviewed-by: Jonas Termansen <sortie@google.com> Commit-Queue: Nate Bosch <nbosch@google.com>
This commit is contained in:
parent
004d49bd6b
commit
557f9121a5
26
PRESUBMIT.py
26
PRESUBMIT.py
|
@ -250,16 +250,24 @@ def _CheckClangTidy(input_api, output_api):
|
||||||
long_text=stdout)
|
long_text=stdout)
|
||||||
]
|
]
|
||||||
|
|
||||||
|
|
||||||
|
def _CommonChecks(input_api, output_api):
|
||||||
|
results = []
|
||||||
|
results.extend(_CheckValidHostsInDEPS(input_api, output_api))
|
||||||
|
results.extend(_CheckDartFormat(input_api, output_api))
|
||||||
|
results.extend(_CheckStatusFiles(input_api, output_api))
|
||||||
|
results.extend(_CheckLayering(input_api, output_api))
|
||||||
|
results.extend(_CheckClangTidy(input_api, output_api))
|
||||||
|
results.extend(
|
||||||
|
input_api.canned_checks.CheckPatchFormatted(input_api, output_api))
|
||||||
|
return results
|
||||||
|
|
||||||
|
|
||||||
def CheckChangeOnCommit(input_api, output_api):
|
def CheckChangeOnCommit(input_api, output_api):
|
||||||
return (_CheckValidHostsInDEPS(input_api, output_api) + _CheckBuildStatus(
|
results = _CommonChecks(input_api, output_api)
|
||||||
input_api, output_api) + _CheckDartFormat(input_api, output_api) +
|
results.extend(_CheckBuildStatus(input_api, output_api))
|
||||||
_CheckStatusFiles(input_api, output_api) + _CheckLayering(
|
return results
|
||||||
input_api, output_api) + _CheckClangTidy(
|
|
||||||
input_api, output_api))
|
|
||||||
|
|
||||||
|
|
||||||
def CheckChangeOnUpload(input_api, output_api):
|
def CheckChangeOnUpload(input_api, output_api):
|
||||||
return (_CheckValidHostsInDEPS(input_api, output_api) + _CheckDartFormat(
|
return _CommonChecks(input_api, output_api)
|
||||||
input_api, output_api) + _CheckStatusFiles(input_api, output_api) +
|
|
||||||
_CheckLayering(input_api, output_api) + _CheckClangTidy(
|
|
||||||
input_api, output_api))
|
|
||||||
|
|
Loading…
Reference in a new issue