languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 02:07:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix build_pkgs.dart to not mutate arguments list. (#30078)

Browse source 
* Fix build_pkgs.dart to not mutate arguments list.

Also remove build of when package since it's apparently gone now.

* Use sublist to remove element.
This commit is contained in:
Bob Nystrom 2017-07-05 12:20:58 -07:00 committed by GitHub
parent d2569cc3ee
commit 52a9e3d9c6
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/dev_compiler/tool/build_pkgs.dart
View file

@ -17,7 +17,9 @@ String outputDirectory;
/// Otherwise, only builds the modules needed by the tests.
void main(List<String> arguments) {
var isTravis = arguments.isNotEmpty && arguments.last == "travis";
if (isTravis) arguments.removeLast();
if (isTravis) {
arguments = arguments.sublist(0, arguments.length - 1);
}
if (arguments.length != 1) {
print("Usage: dart build_pkgs.dart <output_dir> [travis]");
@ -55,7 +57,6 @@ void main(List<String> arguments) {
compileModule('typed_data');
compileModule('usage');
compileModule('utf');
compileModule('when');
}
// Composite packages with dependencies.