From 5173fd2d224f669fd8d0a1d21adbfd6187d10f53 Mon Sep 17 00:00:00 2001 From: Sigmund Cherem Date: Thu, 27 Jan 2022 21:13:41 +0000 Subject: [PATCH] [ddc]: Deprecate public dartdevc scripts Change-Id: I1fdb19e21b4d787090d98cd519e002efebac5e4b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229304 Reviewed-by: Nicholas Shahan --- CHANGELOG.md | 11 +++++++++-- sdk/bin/dartdevc_sdk | 3 +++ sdk/bin/dartdevc_sdk.bat | 3 +++ 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0d2bee122cf..f525e296f7f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -33,9 +33,16 @@ marked deprecated as previously announced. Its replacement is the `dart compile js` command. Should you find any issues, or missing features, in the replacement - command, kindly file [an issue][]. + command, kindly file [an issue](https://github.com/dart-lang/sdk/issues/new). -[an issue]: https://github.com/dart-lang/sdk/issues/new +- **Breaking Change** [#46100](https://github.com/dart-lang/sdk/issues/46100): + The standalone `dartdevc` tool has been marked deprecated as previously + announced and will be deleted in a future Dart stable relase. This tool + was intended for use only by build systems like bazel, `build_web_compilers` + and `flutter_tools`. The functionality remains available for those systems, + but it is no longer exposed as a command-line tool in the SDK. + Please share any concerns in the + [breaking change tracking issue](https://github.com/dart-lang/sdk/issues/46100). - **Breaking Change** [#46100](https://github.com/dart-lang/sdk/issues/46100): The standalone `dartdoc` tool has been removed as diff --git a/sdk/bin/dartdevc_sdk b/sdk/bin/dartdevc_sdk index c687bdd9472..ba71205b090 100755 --- a/sdk/bin/dartdevc_sdk +++ b/sdk/bin/dartdevc_sdk @@ -6,6 +6,9 @@ # Run dev compiler on the Dart VM. This script assumes the Dart SDK's # directory structure. +echo "Warning: this 'dartdevc' script is deprecated and will be removed. " 1>&2 +echo "More details at https://github.com/dart-lang/sdk/issues/46100." 1>&2 + function follow_links() { file="$1" while [ -h "$file" ]; do diff --git a/sdk/bin/dartdevc_sdk.bat b/sdk/bin/dartdevc_sdk.bat index 74b4c185b6a..931e41072f0 100644 --- a/sdk/bin/dartdevc_sdk.bat +++ b/sdk/bin/dartdevc_sdk.bat @@ -3,6 +3,9 @@ REM Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file REM for details. All rights reserved. Use of this source code is governed by a REM BSD-style license that can be found in the LICENSE file. +echo Warning: this 'dartdevc' script is deprecated and will be removed. 1>&2 +echo More details at https://github.com/dart-lang/sdk/issues/46100. 1>&2 + setlocal rem Handle the case where dart-sdk/bin has been symlinked to. set DIR_NAME_WITH_SLASH=%~dp0