languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-01 19:29:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

[dart2js] Don't minify Invocation.memberName

Browse source 
Fixes: #54201
Change-Id: I3cc66263a86668ee46743e46564b175d60143916
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338947
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
This commit is contained in:
Mayank Patke 2023-12-06 18:57:15 +00:00 committed by Commit Queue
parent f53da889cd
commit 4e3cc1cb41
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
CHANGELOG.md
View file

@ -62,6 +62,15 @@
Dart classes. This information provides little value and keeping it imposes an Dart classes. This information provides little value and keeping it imposes an
unnecessary maintenance cost. unnecessary maintenance cost.
#### Production JavaScript compiler (dart2js)
- **Breaking Change** [#54201][]:
The `Invocation` that is passed to `noSuchMethod` will no longer have a
minified `memberName`, even when dart2js is invoked with `--minify`.
See [#54201][] for more details.
[#54201]: https://github.com/dart-lang/sdk/issues/54201
#### Linter #### Linter
- Removed the `iterable_contains_unrelated_type` and - Removed the `iterable_contains_unrelated_type` and

3
pkg/compiler/lib/src/js_emitter/class_stub_generator.dart
View file

@ -185,8 +185,7 @@ class ClassStubGenerator {
'noSuchMethodName': _namer.noSuchMethodName, 'noSuchMethodName': _namer.noSuchMethodName,
'createInvocationMirror': 'createInvocationMirror':
_emitter.staticFunctionAccess(_commonElements.createInvocationMirror), _emitter.staticFunctionAccess(_commonElements.createInvocationMirror),
'methodName': 'methodName': js.quoteName(methodName),
js.quoteName(enableMinification ? internalName : methodName),
'internalName': js.quoteName(internalName), 'internalName': js.quoteName(internalName),
'type': js.number(type), 'type': js.number(type),
'arguments': jsAst.ArrayInitializer( 'arguments': jsAst.ArrayInitializer(