languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 16:41:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add a test to ensure that a single diagnostic never has multiple bulk appliable fixes

Browse source 
This includes an allow list for the diagnostics that we're already
approved, and we can add more as needed, but I don't want us to have
multiple bulk fixes without first confirming that they are mutually
exclusive. This should help prevent an oversight.

Change-Id: I73c4a52e36005f256b416372bfbf8bf7db38400e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214424
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
Brian Wilkerson 2021-09-24 19:24:39 +00:00 committed by commit-bot@chromium.org
parent 8a9a2e4066
commit 4daa1ed206
1 changed files with 40 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

52
pkg/analysis_server/test/src/services/correction/fix/fix_processor_map_test.dart
View file

@ -15,12 +15,20 @@ void main() {
@reflectiveTest
class FixProcessorMapTest {
static const List<String> lintsAllowedToHaveMultipleBulkFixes = [
'avoid_types_on_closure_parameters',
'empty_statements',
'prefer_collection_literals',
'prefer_inlined_adds',
];
void test_lintProducerMap() {
_testMap(FixProcessor.lintProducerMap.values);
_assertMap(FixProcessor.lintProducerMap.entries,
lintsAllowedToHaveMultipleBulkFixes);
}
void test_nonLintProducerMap() {
_testMap(FixProcessor.nonLintProducerMap.values);
_assertMap(FixProcessor.nonLintProducerMap.entries);
}
void test_registerFixForLint() {
@ -34,8 +42,36 @@ class FixProcessorMapTest {
FixProcessor.lintProducerMap.remove(lintName);
}
void _testGenerator(ProducerGenerator generator) {
var producer = generator();
void _assertMap<K>(Iterable<MapEntry<K, List<ProducerGenerator>>> entries,
[List<String> keysAllowedToHaveMultipleBulkFixes = const []]) {
var list = <String>[];
for (var entry in entries) {
var bulkCount = 0;
for (var generator in entry.value) {
var producer = generator();
_assertValidProducer(producer);
if (producer.canBeAppliedInBulk) {
bulkCount++;
}
}
if (bulkCount > 1) {
var key = entry.key.toString();
if (!keysAllowedToHaveMultipleBulkFixes.contains(key)) {
list.add(key);
}
}
}
if (list.isNotEmpty) {
var buffer = StringBuffer();
buffer.writeln('Multiple bulk fixes for');
for (var code in list) {
buffer.writeln('- $code');
}
fail(buffer.toString());
}
}
void _assertValidProducer(CorrectionProducer producer) {
var className = producer.runtimeType.toString();
expect(producer.fixKind, isNotNull, reason: '$className.fixKind');
if (producer.canBeAppliedToFile) {
@ -43,14 +79,6 @@ class FixProcessorMapTest {
reason: '$className.multiFixKind');
}
}
void _testMap(Iterable<List<ProducerGenerator>> values) {
for (var generators in values) {
for (var generator in generators) {
_testGenerator(generator);
}
}
}
}
class MockCorrectionProducer implements CorrectionProducer {