[tests] Removing List constructor usage in corelib tests.

Replacing usage of deprecated `new List()` and `new List(x)` in tests
with `List.filled` or `[]` where applicable.

Change-Id: Ie52a1869dfa25e141a8486c02c2d7668e9303ec9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141022
Reviewed-by: Riley Porter <rileyporter@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Riley Porter <rileyporter@google.com>

tests/corelib/linked_hash_map_test.dart

@@ -17,8 +17,8 @@ class LinkedHashMapTest {
     map["d"] = 4;
     map["e"] = 5;
 
-    List<String?> keys = new List<String?>(5);
-    List<int?> values = new List<int?>(5);
+    List<String?> keys = new List<String?>.filled(5, null);
+    List<int?> values = new List<int?>.filled(5, null);
 
     int index = 0;
 

tests/corelib/list_as_map_test.dart

@@ -85,11 +85,11 @@ void testAsMap(List list) {
 main() {
   testConstAsMap(const [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]);
   testAsMap([1, 2, 3, 4, 5, 6, 7, 8, 9, 10]);
-  List list = new List(10);
+  List list = new List.filled(10, null);
   for (int i = 0; i < 10; i++) list[i] = i + 1;
   testFixedAsMap(list);
 
   testConstAsMap(const []);
   testAsMap([]);
-  testFixedAsMap(new List(0));
+  testFixedAsMap(new List.empty());
 }

tests/corelib/list_contains_argument_order_test.dart

@@ -14,6 +14,7 @@ class A {
 class B {
   bool operator ==(Object other) {
     Expect.fail("Bad equality order.");
+    return false;
   }
 }
 
@@ -25,7 +26,6 @@ main() {
   var iterables = <dynamic>[
     <A>[new A()],
     new List<A>.filled(1, new A()),
-    new List<A>()..add(new A()),
     const <A>[const A()],
     new Set()..add(new A()),
     (new Map()..[new A()] = 0).keys,

tests/corelib/list_fixed_test.dart

@@ -7,7 +7,7 @@ import "package:expect/expect.dart";
 main() {
   var a;
 
-  a = new List(42);
+  a = new List<int?>.filled(42, null);
   Expect.equals(42, a.length);
   Expect.throwsUnsupportedError(() => a.add(499));
   Expect.equals(42, a.length);

tests/corelib/list_for_each_test.dart

@@ -35,10 +35,10 @@ void testWithModification(List list) {
 }
 
 main() {
-  List fixedLengthList = new List(10);
+  List fixedLengthList = new List.filled(10, null);
   for (int i = 0; i < 10; i++) fixedLengthList[i] = i + 1;
 
-  List growableList = new List();
+  List growableList = [];
   growableList.length = 10;
   for (int i = 0; i < 10; i++) growableList[i] = i + 1;
 

tests/corelib/list_growable_test.dart

@@ -6,7 +6,7 @@ import "package:expect/expect.dart";
 
 main() {
   var a;
-  a = new List();
+  a = [];
   a.add(499);
   Expect.equals(1, a.length);
   Expect.equals(499, a[0]);
@@ -14,7 +14,7 @@ main() {
   Expect.equals(0, a.length);
   Expect.throwsRangeError(() => a[0]);
 
-  a = new List(42).toList();
+  a = new List<int?>.filled(42, null).toList();
   Expect.equals(42, a.length);
   a.add(499);
   Expect.equals(43, a.length);
@@ -24,7 +24,7 @@ main() {
   Expect.equals(0, a.length);
   Expect.throwsRangeError(() => a[0]);
 
-  a = new List<int?>(42).toList();
+  a = new List<int?>.filled(42, null).toList();
   Expect.equals(42, a.length);
   a.add(499);
   Expect.equals(43, a.length);

tests/corelib/list_index_of_test.dart

@@ -5,8 +5,8 @@
 import "package:expect/expect.dart";
 
 main() {
-  test(new List<int?>(5));
-  var l = new List<int?>();
+  test(new List<int?>.filled(5, null));
+  var l = <int?>[];
   l.length = 5;
   test(l);
 }

tests/corelib/list_insert_test.dart

@@ -46,7 +46,7 @@ void main() {
   testModifiableList(new MyList([0, 1, 2, 3, 4]));
 
   // Fixed size list.
-  var l2 = new List(5);
+  var l2 = new List<int?>.filled(5, null);
   for (var i = 0; i < 5; i++) l2[i] = i;
   Expect.throwsUnsupportedError(() => l2.insert(2, 5), "fixed-length");
 

tests/corelib/list_iterators_test.dart

@@ -18,10 +18,9 @@ class ListIteratorsTest {
   static testMain() {
     checkListIterator([]);
     checkListIterator([1, 2]);
-    checkListIterator(new List(0));
-    checkListIterator(new List(10));
-    checkListIterator(new List());
-    List g = new List();
+    checkListIterator(new List.empty());
+    checkListIterator(new List.filled(10, null));
+    List g = [];
     g.addAll([1, 2, 3]);
     checkListIterator(g);
 

tests/corelib/list_set_range_test.dart

@@ -77,7 +77,7 @@ void testNegativeIndices() {
 }
 
 void testNonExtendableList() {
-  var list = new List<int?>(6);
+  var list = new List<int?>.filled(6, null);
   Expect.listEquals([null, null, null, null, null, null], list);
   list.setRange(0, 3, [1, 2, 3, 4]);
   list.setRange(3, 6, [1, 2, 3, 4]);

tests/corelib/list_to_string2_test.dart

@@ -8,7 +8,7 @@ main() {
   List list = [1, 2];
   list.add(list);
 
-  List list2 = new List(4);
+  List list2 = new List.filled(4, null);
   list2[0] = 1;
   list2[1] = 2;
   list2[2] = list2;

tests/corelib/range_error_test.dart

@@ -22,14 +22,9 @@ void testRead() {
   testListRead(list, -1);
   testListRead(list, 1);
 
-  list = new List(1);
+  list = new List.filled(1, null);
   testListRead(list, -1);
   testListRead(list, 1);
-
-  list = new List();
-  testListRead(list, -1);
-  testListRead(list, 0);
-  testListRead(list, 1);
 }
 
 void testWrite() {
@@ -41,14 +36,9 @@ void testWrite() {
   testListWrite(list, -1);
   testListWrite(list, 1);
 
-  list = new List(1);
+  list = new List.filled(1, null);
   testListWrite(list, -1);
   testListWrite(list, 1);
-
-  list = new List();
-  testListWrite(list, -1);
-  testListWrite(list, 0);
-  testListWrite(list, 1);
 }
 
 void testToString() {

tests/corelib/string_base_vm_test.dart

@@ -27,8 +27,8 @@ class StringBaseTest {
 
   static testCreation() {
     String s = "Hello";
-    List<int> a = new List.filled(s.length, -1);
-    List<int> ga = new List();
+    List<int> a = new List<int>.filled(s.length, -1);
+    List<int> ga = [];
     bool exception_caught = false;
     for (int i = 0; i < a.length; i++) {
       a[i] = s.codeUnitAt(i);

tests/corelib/string_from_list_test.dart

@@ -13,7 +13,6 @@ void main() {
   Expect.equals("Ærø", new String.fromCharCodes(const [0xc6, 0x72, 0xf8]));
   Expect.equals("\u{1234}", new String.fromCharCodes([0x1234]));
   Expect.equals("\u{12345}*", new String.fromCharCodes([0x12345, 42]));
-  Expect.equals("", new String.fromCharCodes(new List()));
   {
     var a = <int>[];
     a.add(65);