languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 16:37:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't rewrite error Severity for special cases of front-end testing.

Browse source 
IIUC this rewriting was done to internally check front-end better, but
it get in the way of running analyzer, and these errors are not mandated
by the spec. So, I decided that I don't want doing rewriting in
Analyzer / CFE integration.

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/34042
Change-Id: I1bb41b271d8d84eace9bd13a269bcac157e9f89b
Reviewed-on: https://dart-review.googlesource.com/68006
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This commit is contained in:
Konstantin Shcheglov 2018-08-02 15:41:12 +00:00 committed by commit-bot@chromium.org
parent d6189709b8
commit 4bb3fb6cae
2 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/analyzer/lib/src/dart/analysis/frontend_resolution.dart
View file

@ -475,6 +475,9 @@ class _AnalyzerSourceLoader<L> extends SourceLoader<L> {
return new _AnalyzerOutlineListener(fileUri, resolution);
}
@override
Severity rewriteSeverity(severity, message, fileUri) => severity;
CollectedResolution _fileResolution(Uri fileUri) {
CollectedResolution resolution = _fileResolutions[fileUri];
if (resolution == null) {

8
pkg/front_end/lib/src/fasta/loader.dart
View file

@ -26,7 +26,7 @@ import 'messages.dart'
import 'problems.dart' show internalProblem;
import 'rewrite_severity.dart' show rewriteSeverity;
import 'rewrite_severity.dart' as rewrite_severity;
import 'severity.dart' show Severity;
@ -243,7 +243,7 @@ abstract class Loader<L> {
bool addMessage(Message message, int charOffset, int length, Uri fileUri,
Severity severity,
{bool wasHandled: false, List<LocatedMessage> context}) {
severity = rewriteSeverity(severity, message.code, fileUri);
severity = rewriteSeverity(severity, message, fileUri);
if (severity == Severity.ignored) return false;
String trace = """
message: ${message.message}
@ -271,6 +271,10 @@ severity: $severity
return true;
}
Severity rewriteSeverity(Severity severity, Message message, Uri fileUri) {
return rewrite_severity.rewriteSeverity(severity, message.code, fileUri);
}
Declaration getAbstractClassInstantiationError() {
return target.getAbstractClassInstantiationError(this);
}