languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-06 00:59:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Better way of fixing attribute_changed_callback_test, doesn't require a timer

Browse source 
BUG=

Review URL: https://codereview.chromium.org//1061403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44946 260f80e4-7a28-3924-810f-c04153c831b5
This commit is contained in:
alanknight@google.com 2015-04-07 20:52:54 +00:00
parent 8c4caa642b
commit 4b119a94d8
1 changed files with 16 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
tests/html/custom/attribute_changed_callback_test.dart
View file

@ -32,8 +32,14 @@ class B extends HtmlElement {
static var invocations = [];
Completer completer;
void attributeChanged(name, oldValue, newValue) {
invocations.add('$name: $oldValue => $newValue');
if (completer != null) {
completer.complete('value changed to $newValue');
completer = null;
}
}
}
@ -90,16 +96,19 @@ main() {
B.invocations = [];
var b = new B();
var completer = new Completer();
b.completer = completer;
b.id = 'x';
return new Future.delayed(new Duration(milliseconds: 1))
return completer.future
.then((_) => expect(B.invocations, ['created', 'id: null => x']))
.then((_) {
B.invocations = [];
b.attributes.remove('id');
})
.then((_) => new Future.delayed(new Duration(milliseconds: 1)))
.then((_) => expect(B.invocations, ['id: x => null']));
B.invocations = [];
var secondCompleter = new Completer();
b.completer = secondCompleter;
b.attributes.remove('id');
return secondCompleter.future;
})
.then((_) => expect(B.invocations, ['id: x => null']));
});
});