languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-06 00:59:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Store invalid deferred types used in bodies.

Browse source 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Id9f6309b5a9af69d38305c538bacb967c4565793
Reviewed-on: https://dart-review.googlesource.com/67688
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
This commit is contained in:
Konstantin Shcheglov 2018-08-01 00:54:09 +00:00 committed by commit-bot@chromium.org
parent 89cfa2edd7
commit 4b07df24dd
3 changed files with 22 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
pkg/analyzer/test/generated/static_warning_code_kernel_test.dart
View file

@ -569,18 +569,6 @@ class StaticWarningCodeTest_Kernel extends StaticWarningCodeTest_Driver {
return super.test_switchExpressionNotAssignable();
}
@override
@failingTest
test_typeAnnotationDeferredClass_asExpression() {
return super.test_typeAnnotationDeferredClass_asExpression();
}
@override
@failingTest
test_typeAnnotationDeferredClass_catchClause() {
return super.test_typeAnnotationDeferredClass_catchClause();
}
@override
@failingTest
test_typeAnnotationDeferredClass_functionDeclaration_returnType() async {
@ -588,12 +576,6 @@ class StaticWarningCodeTest_Kernel extends StaticWarningCodeTest_Driver {
.test_typeAnnotationDeferredClass_functionDeclaration_returnType();
}
@override
@failingTest
test_typeAnnotationDeferredClass_isExpression() {
return super.test_typeAnnotationDeferredClass_isExpression();
}
@override
@failingTest
test_typeAnnotationDeferredClass_methodDeclaration_returnType() async {

20
pkg/analyzer/test/src/dart/analysis/driver_resolution_test.dart
View file

@ -3815,6 +3815,26 @@ class A {
assertType(aRef, 'int');
}
test_invalid_deferred_type_localVariable() async {
addTestFile(r'''
import 'dart:async' deferred as a;
main() {
a.Future<int> v;
}
''');
await resolveTestFile();
expect(result.errors, isNotEmpty);
assertTypeName(
findNode.typeName('a.Future'),
futureElement,
'Future<int>',
expectedPrefix: findElement.import('dart:async').prefix,
);
assertTypeName(findNode.typeName('int>'), intElement, 'int');
}
test_invalid_fieldInitializer_field() async {
addTestFile(r'''
class C {

3
pkg/front_end/lib/src/fasta/kernel/expression_generator.dart
View file

@ -528,7 +528,8 @@ abstract class DeferredAccessGenerator implements Generator {
helper.addProblem(
templateDeferredTypeAnnotation.withArguments(
suffixGenerator.buildTypeWithBuiltArguments(arguments,
nonInstanceAccessIsError: nonInstanceAccessIsError),
nonInstanceAccessIsError: nonInstanceAccessIsError,
typeInferrer: typeInferrer),
prefixGenerator.plainNameForRead),
offsetForToken(prefixGenerator.token),
lengthOfSpan(prefixGenerator.token, token));