languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 12:24:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

[VM] Relax assertions in NativeArguments allowing native generic functions

Browse source 
NativeArguments don't allow you to access type arguments, but calling
conventions are setup in such a way that nothing else needs to be 
changed.

This is needed because we changed

List makeListFixedLength(List growableList)
    native "Internal_makeListFixedLength";

to 

List<T> makeListFixedLength<T>(List<T> growableList)
    native "Internal_makeListFixedLength";

Bug:
Change-Id: I2f8755f25c488a422a60f3efce2541de7cbeae0e
Reviewed-on: https://dart-review.googlesource.com/15080
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
This commit is contained in:
Vyacheslav Egorov 2017-10-19 07:13:06 +00:00
parent dcfb7b9a4c
commit 47ed51fe3f
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
runtime/vm/native_arguments.h
View file

@ -151,7 +151,6 @@ class NativeArguments {
static intptr_t ParameterCountForResolution(const Function& function) {
ASSERT(function.is_native());
ASSERT(!function.IsGeneric()); // Not supported.
ASSERT(!function.IsGenerativeConstructor()); // Not supported.
intptr_t count = function.NumParameters();
if (function.is_static() && function.IsClosureFunction()) {
@ -166,7 +165,6 @@ class NativeArguments {
static int ComputeArgcTag(const Function& function) {
ASSERT(function.is_native());
ASSERT(!function.IsGeneric()); // Not supported.
ASSERT(!function.IsGenerativeConstructor()); // Not supported.
int tag = ArgcBits::encode(function.NumParameters());
int function_bits = 0;