languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-06 13:47:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[gardening] Fix gen_snapshot crash on msvc.

Browse source 
Revert change to StringRAII which used to take reference, but was changed to take pointer in 2ead86ab9d

Fixes https://github.com/dart-lang/sdk/issues/49978
TEST=ci

Change-Id: I8d8b18e6e9ae3cd07427ee1b37df404d11dcb26e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260402
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>
This commit is contained in:
Alexander Aprelev 2022-09-21 18:16:56 +00:00 committed by Commit Bot
parent 1bbb01211d
commit 46bc947e75
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
runtime/bin/file_win.cc
View file

@ -323,9 +323,9 @@ File* File::OpenFD(int fd) {
class StringRAII {
public:
explicit StringRAII(StringRAII* origin) {
own_ = origin->own_;
s_ = origin->release();
explicit StringRAII(StringRAII& origin) { // NOLINT
own_ = origin.own_;
s_ = origin.release();
}
explicit StringRAII(const char* s) : s_(s), own_(false) {}