mirror of
https://github.com/dart-lang/sdk
synced 2024-10-01 19:29:09 +00:00
Adds deprecation messages for MIPS cross-builds
fixes #29678 R=asiva@google.com Review-Url: https://codereview.chromium.org/2899803002 .
This commit is contained in:
parent
34f601a8db
commit
467dad857e
|
@ -46,7 +46,6 @@ entirely to allow inference to fill in the type.
|
|||
1.24, violations are only reported (on stdout or stderr), but a future
|
||||
version of the Dart SDK will change this to throwing a `StateError`.
|
||||
|
||||
|
||||
### Dart VM
|
||||
|
||||
### Tool Changes
|
||||
|
@ -61,6 +60,12 @@ entirely to allow inference to fill in the type.
|
|||
* Add self-test validation to ensure formatter bugs do not cause user code
|
||||
to be lost.
|
||||
|
||||
### Infrastructure changes
|
||||
|
||||
* As of this release, we'll show a warning when using the MIPS architecture.
|
||||
Unless we learn about any critical use of Dart on MIPS in the meantime, we're
|
||||
planning to deprecate support for MIPS starting with the next stable release.
|
||||
|
||||
## 1.23.0
|
||||
|
||||
#### Strong Mode
|
||||
|
|
|
@ -99,7 +99,7 @@ def ProcessOsOption(os_name):
|
|||
|
||||
def ProcessOptions(options, args):
|
||||
if options.arch == 'all':
|
||||
options.arch = 'ia32,x64,simarm,simarm64,simmips,simdbc64'
|
||||
options.arch = 'ia32,x64,simarm,simarm64,simdbc64'
|
||||
if options.mode == 'all':
|
||||
options.mode = 'debug,release,product'
|
||||
if options.os == 'all':
|
||||
|
@ -484,6 +484,13 @@ def BuildNinjaCommand(options, target, target_os, mode, arch):
|
|||
filter_xcodebuild_output = False
|
||||
def BuildOneConfig(options, target, target_os, mode, arch):
|
||||
global filter_xcodebuild_output
|
||||
if arch.startswith('mips'):
|
||||
bold = '\033[1m'
|
||||
reset = '\033[0m'
|
||||
print(bold + "Warning: MIPS architectures are unlikely to be supported in "
|
||||
"upcoming releases. Please consider using another architecture "
|
||||
"and/or file an issue explaining your specific use of and need for "
|
||||
"MIPS support." + reset)
|
||||
start_time = time.time()
|
||||
args = []
|
||||
build_config = utils.GetBuildConf(mode, arch, target_os)
|
||||
|
|
10
tools/gn.py
10
tools/gn.py
|
@ -146,6 +146,14 @@ def ToGnArgs(args, mode, arch, target_os):
|
|||
else:
|
||||
gn_args['target_os'] = target_os
|
||||
|
||||
if arch.startswith('mips'):
|
||||
bold = '\033[1m'
|
||||
reset = '\033[0m'
|
||||
print(bold + "Warning: MIPS architectures are unlikely to be supported in "
|
||||
"upcoming releases. Please consider using another architecture "
|
||||
"and/or file an issue explaining your specific use of and need for "
|
||||
"MIPS support." + reset)
|
||||
|
||||
gn_args['dart_target_arch'] = arch
|
||||
gn_args['target_cpu'] = TargetCpuForArch(arch, target_os)
|
||||
gn_args['host_cpu'] = HostCpuForArch(arch)
|
||||
|
@ -250,7 +258,7 @@ def ProcessOsOption(os_name):
|
|||
|
||||
def ProcessOptions(args):
|
||||
if args.arch == 'all':
|
||||
args.arch = 'ia32,x64,simarm,simarm64,simmips,simdbc64'
|
||||
args.arch = 'ia32,x64,simarm,simarm64,simdbc64'
|
||||
if args.mode == 'all':
|
||||
args.mode = 'debug,release,product'
|
||||
if args.os == 'all':
|
||||
|
|
|
@ -62,7 +62,7 @@ def ProcessOsOption(os_name):
|
|||
|
||||
def ProcessOptions(options, args):
|
||||
if options.arch == 'all':
|
||||
options.arch = 'ia32,x64,simarm,simarm64,simmips,simdbc64'
|
||||
options.arch = 'ia32,x64,simarm,simarm64,simdbc64'
|
||||
if options.mode == 'all':
|
||||
options.mode = 'debug,release,product'
|
||||
if options.os == 'all':
|
||||
|
@ -225,6 +225,13 @@ def EnsureGomaStarted(out_dir):
|
|||
|
||||
# Returns a tuple (build_config, command to run, whether goma is used)
|
||||
def BuildOneConfig(options, targets, target_os, mode, arch):
|
||||
if arch.startswith('mips'):
|
||||
bold = '\033[1m'
|
||||
reset = '\033[0m'
|
||||
print(bold + "Warning: MIPS architectures are unlikely to be supported in "
|
||||
"upcoming releases. Please consider using another architecture "
|
||||
"and/or file an issue explaining your specific use of and need for "
|
||||
"MIPS support." + reset)
|
||||
build_config = utils.GetBuildConf(mode, arch, target_os)
|
||||
out_dir = utils.GetBuildRoot(HOST_OS, mode, arch, target_os)
|
||||
using_goma = False
|
||||
|
|
Loading…
Reference in a new issue