languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 04:47:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "[build] Debug means debug!"

Browse source 
This reverts commit 984c407bb3.

Reason for revert:
This change causes failures on the flutter engine tests.
Reverting for now to unblock the Dart roll.

https://github.com/dart-lang/sdk/issues/34872


Original change's description:
> [build] Debug means debug!
> 
> Bug: https://github.com/dart-lang/sdk/issues/29458
> Change-Id: Ic7d4cb81c65da9c7a8970431b4e02f3d2d19e556
> Reviewed-on: https://dart-review.googlesource.com/c/77980
> Reviewed-by: Siva Annamalai <asiva@google.com>
> Reviewed-by: Zach Anderson <zra@google.com>
> Commit-Queue: Ryan Macnak <rmacnak@google.com>

TBR=rmacnak@google.com,zra@google.com,asiva@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: https://github.com/dart-lang/sdk/issues/29458
Change-Id: I45ea9e1408d71e79d28d8ff0f5aea7649d5fb2ac
Reviewed-on: https://dart-review.googlesource.com/c/80920
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
This commit is contained in:
Aart Bik 2018-10-19 19:27:56 +00:00
parent 9f7ad8d082
commit 45f9462398
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
runtime/runtime_args.gni
View file

@ -6,7 +6,7 @@ declare_args() {
# Instead of using is_debug, we introduce a different flag for specifying a
# Debug build of Dart so that clients can still use a Release build of Dart
# while themselves doing a Debug build.
dart_debug = is_debug
dart_debug = false
# Set the runtime mode. This affects how the runtime is built and what
# features it has. Valid values are: