mirror of
https://github.com/dart-lang/sdk
synced 2024-09-05 16:41:07 +00:00
Fix product build compile and ensure all tests run cleanly again.
R=srdjan@google.com Review URL: https://codereview.chromium.org/1921343002 .
This commit is contained in:
parent
7684794b8b
commit
4547165abe
|
@ -29,7 +29,7 @@
|
|||
#define FLAG_LIST(P, R, D, C) \
|
||||
P(always_megamorphic_calls, bool, false, \
|
||||
"Instance call always as megamorphic.") \
|
||||
C(background_compilation, false, true, bool, true, \
|
||||
P(background_compilation, bool, true, \
|
||||
"Run optimizing compilation in background") \
|
||||
R(background_compilation_stop_alot, false, bool, false, \
|
||||
"Stress test system: stop background compiler often.") \
|
||||
|
|
|
@ -79,6 +79,7 @@ static void PrecompilationModeHandler(bool value) {
|
|||
FLAG_inlining_constant_arguments_max_size_threshold = 100;
|
||||
FLAG_inlining_constant_arguments_min_size_threshold = 30;
|
||||
|
||||
FLAG_background_compilation = false;
|
||||
FLAG_always_megamorphic_calls = true;
|
||||
FLAG_collect_dynamic_function_names = true;
|
||||
FLAG_fields_may_be_reset = true;
|
||||
|
@ -95,7 +96,6 @@ static void PrecompilationModeHandler(bool value) {
|
|||
|
||||
#if !defined(PRODUCT) && !defined(DART_PRECOMPILED_RUNTIME)
|
||||
// Set flags affecting runtime accordingly for dart_noopt.
|
||||
FLAG_background_compilation = false;
|
||||
FLAG_collect_code = false;
|
||||
FLAG_support_debugger = false;
|
||||
FLAG_deoptimize_alot = false; // Used in some tests.
|
||||
|
@ -114,7 +114,6 @@ DEFINE_FLAG_HANDLER(PrecompilationModeHandler,
|
|||
|
||||
#ifdef DART_PRECOMPILED_RUNTIME
|
||||
|
||||
COMPILE_ASSERT(!FLAG_background_compilation);
|
||||
COMPILE_ASSERT(!FLAG_collect_code);
|
||||
COMPILE_ASSERT(!FLAG_deoptimize_alot); // Used in some tests.
|
||||
COMPILE_ASSERT(!FLAG_enable_mirrors);
|
||||
|
|
|
@ -15515,6 +15515,7 @@ TokenPosition AbstractType::token_pos() const {
|
|||
|
||||
bool AbstractType::IsInstantiated(TrailPtr trail) const {
|
||||
// AbstractType is an abstract class.
|
||||
#if !defined(PRODUCT)
|
||||
// TODO(srdjan) : Remove temporary code.
|
||||
NOT_IN_PRODUCT(
|
||||
Profiler::DumpStackTrace(true); // Only native stack trace.
|
||||
|
@ -15522,6 +15523,7 @@ NOT_IN_PRODUCT(
|
|||
if (Compiler::IsBackgroundCompilation()) {
|
||||
UNREACHABLE();
|
||||
}
|
||||
#endif
|
||||
UNREACHABLE();
|
||||
return false;
|
||||
}
|
||||
|
|
|
@ -29,4 +29,4 @@ sample_extension/test/sample_extension_test: Skip # Issue 14705
|
|||
*: Skip
|
||||
|
||||
[ $noopt || $runtime == dart_precompiled || $runtime == dart_product ]
|
||||
sample_extension: RuntimeError # Platform.executable
|
||||
sample_extension: Skip # Platform.executable
|
||||
|
|
Loading…
Reference in a new issue