languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 12:24:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

[vm] Don't unnecessarily extend lifetime of KernelLoader handles.

Browse source 
ZoneHandles out-live the HANDLESCOPE for class finalization, and can accumulate a lot of objects during FinalizeAllClasses.

TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/54886
Change-Id: Ia1330e0f27770c1a786a1b70e56881127cd936b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352052
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
This commit is contained in:
Ryan Macnak 2024-02-13 17:30:29 +00:00 committed by Commit Queue
parent 106db0d7b4
commit 448b9ef989
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
runtime/vm/kernel_loader.cc
View file

@ -193,13 +193,13 @@ KernelLoader::KernelLoader(Program* program,
thread_(Thread::Current()),
zone_(thread_->zone()),
no_active_isolate_scope_(),
patch_classes_(Array::ZoneHandle(zone_)),
patch_classes_(Array::Handle(zone_)),
active_class_(),
library_kernel_offset_(-1), // Set to the correct value in LoadLibrary
correction_offset_(-1), // Set to the correct value in LoadLibrary
loading_native_wrappers_library_(false),
library_kernel_data_(TypedDataView::ZoneHandle(zone_)),
kernel_program_info_(KernelProgramInfo::ZoneHandle(zone_)),
library_kernel_data_(TypedDataView::Handle(zone_)),
kernel_program_info_(KernelProgramInfo::Handle(zone_)),
translation_helper_(this, thread_, Heap::kOld),
helper_(zone_,
&translation_helper_,
@ -457,13 +457,13 @@ KernelLoader::KernelLoader(const KernelProgramInfo& kernel_program_info,
thread_(Thread::Current()),
zone_(thread_->zone()),
no_active_isolate_scope_(),
patch_classes_(Array::ZoneHandle(zone_)),
patch_classes_(Array::Handle(zone_)),
library_kernel_offset_(data_program_offset),
correction_offset_(0),
loading_native_wrappers_library_(false),
library_kernel_data_(TypedDataView::ZoneHandle(zone_)),
library_kernel_data_(TypedDataView::Handle(zone_)),
kernel_program_info_(
KernelProgramInfo::ZoneHandle(zone_, kernel_program_info.ptr())),
KernelProgramInfo::Handle(zone_, kernel_program_info.ptr())),
translation_helper_(this, thread_, Heap::kOld),
helper_(zone_, &translation_helper_, kernel_data, 0),
constant_reader_(&helper_, &active_class_),
@ -1901,7 +1901,7 @@ const Object& KernelLoader::ClassForScriptAt(const Class& klass,
}
// Use cache for patch classes. This works best for in-order usages.
PatchClass& patch_class = PatchClass::ZoneHandle(Z);
PatchClass& patch_class = PatchClass::Handle(Z);
patch_class ^= patch_classes_.At(source_uri_index);
if (patch_class.IsNull() || patch_class.wrapped_class() != klass.ptr()) {
const auto& lib = Library::Handle(klass.library());