languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 22:59:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

[dart2js] Rewrite lib/html/js_typed_interop_type_test to use external

Browse source 
fields.

This brings it more in line with the lib_2 version.

Change-Id: I99e4f6a467fa5b58d6e7c5206e1f6d9956fc60bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158961
Auto-Submit: Mayank Patke <fishythefish@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
This commit is contained in:
Mayank Patke 2020-08-18 15:46:20 +00:00 committed by commit-bot@chromium.org
parent a51f1747e0
commit 41953c8835
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/compiler/lib/src/diagnostics/messages.dart
View file

@ -203,8 +203,7 @@ class MessageTemplate {
MessageKind.JS_INTEROP_CLASS_NON_EXTERNAL_MEMBER: const MessageTemplate(
MessageKind.JS_INTEROP_CLASS_NON_EXTERNAL_MEMBER,
"Member '#{member}' in js-interop class '#{cls}' is not external.",
howToFix: "Try adding 'external' to '#{member}'. If #{member} is a "
"`late` field, use an `external` getter/setter instead.",
howToFix: "Try adding 'external' to '#{member}'.",
examples: const [
"""
import 'package:js/js.dart';

4
tests/lib/html/js_typed_interop_type_test.dart
View file

@ -26,7 +26,7 @@ class B {
@JS()
@anonymous
class C {
external get foo;
external final foo;
external factory C({foo});
}
@ -34,7 +34,7 @@ class C {
@JS()
@anonymous
class D {
external get foo;
external final foo;
external factory D({foo});
}