mirror of
https://github.com/dart-lang/sdk
synced 2024-09-05 00:13:50 +00:00
[infra] Fix handling of deflaking a list of tests
An error was introduced by https://dart-review.googlesource.com/c/sdk/+/313567 when the --default-suites flag is used along with a list of tests to deflake. The suites in the list of tests should be the only suites used as selectors, and should replace any other input selectors. Bug: b/290617138 Change-Id: Ic43c1409df621bbaf852276fbaa16ce4961a9549 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/314061 Auto-Submit: William Hesse <whesse@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com> Commit-Queue: William Hesse <whesse@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
This commit is contained in:
parent
5db0c2b546
commit
416b43faaa
|
@ -850,8 +850,10 @@ has been specified on the command line.''')
|
||||||
var suitePath = Path(configuration['suite-dir'] as String);
|
var suitePath = Path(configuration['suite-dir'] as String);
|
||||||
selectors.add(suitePath.filename);
|
selectors.add(suitePath.filename);
|
||||||
} else if (configuration['test-list-contents'] != null) {
|
} else if (configuration['test-list-contents'] != null) {
|
||||||
selectors.addAll((configuration['test-list-contents'] as List<String>)
|
selectors = (configuration['test-list-contents'] as List<String>)
|
||||||
.map((t) => t.split('/').first));
|
.map((t) => t.split('/').first)
|
||||||
|
.toSet()
|
||||||
|
.toList();
|
||||||
} else {
|
} else {
|
||||||
if (nnbdMode == NnbdMode.legacy) {
|
if (nnbdMode == NnbdMode.legacy) {
|
||||||
selectors.addAll(_legacyTestSelectors);
|
selectors.addAll(_legacyTestSelectors);
|
||||||
|
|
Loading…
Reference in a new issue