languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 10:49:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix analyzer warnings in js_util_test, skip js_util_test in csp mode and baseline expectations for analyze_library.status

Browse source 
Update pkg/js CHANGELOG.md to address comment from previous CL.

BUG=

Review URL: https://codereview.chromium.org/2179153002 .
This commit is contained in:
Jacob Richman 2016-07-25 13:20:25 -07:00
parent eb7f2d6fcc
commit 410cde6023
4 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/js/CHANGELOG.md
View file

@ -1,8 +1,7 @@
## 0.6.1 ## 0.6.1
* Add js_util library of utility methods to efficiently manipulate typed * Add js_util library of utility methods to efficiently manipulate typed
JavaScript interop objects in cases where the member name is not known JavaScript interop objects in cases where the member name is not known
statically. These methods would be extension methods on JSObject if statically.
Dart supported extension methods.
## 0.6.0 ## 0.6.0

1
tests/html/html.status
View file

@ -357,6 +357,7 @@ event_customevent_test: SkipByDesign
js_interop_1_test: SkipByDesign js_interop_1_test: SkipByDesign
js_test: SkipByDesign js_test: SkipByDesign
js_array_test: SkipByDesign js_array_test: SkipByDesign
js_util_test: SkipByDesign
js_typed_interop_bind_this_test: SkipByDesign js_typed_interop_bind_this_test: SkipByDesign
js_typed_interop_callable_object_test: SkipByDesign js_typed_interop_callable_object_test: SkipByDesign
js_typed_interop_test: SkipByDesign js_typed_interop_test: SkipByDesign

12
tests/html/js_util_test.dart
View file

@ -68,16 +68,16 @@ external bool checkMap(m, String, value);
external String stringify(o); external String stringify(o);
@JS('Node') @JS('Node')
external Function get JSNodeType; external get JSNodeType;
@JS('Element') @JS('Element')
external Function get JSElementType; external get JSElementType;
@JS('Text') @JS('Text')
external Function get JSTextType; external get JSTextType;
@JS('HTMLCanvasElement') @JS('HTMLCanvasElement')
external Function get JSHtmlCanvasElementType; external get JSHtmlCanvasElementType;
@JS() @JS()
class Foo { class Foo {
@ -88,7 +88,7 @@ class Foo {
} }
@JS('Foo') @JS('Foo')
external Function get JSFooType; external get JSFooType;
@JS() @JS()
@anonymous @anonymous
@ -106,7 +106,7 @@ class ExampleTypedLiteral {
} }
@JS("Object.prototype.hasOwnProperty") @JS("Object.prototype.hasOwnProperty")
external Function get _hasOwnProperty; external get _hasOwnProperty;
bool hasOwnProperty(o, String name) { bool hasOwnProperty(o, String name) {
return js_util.callMethod(_hasOwnProperty, 'call', [o, name]); return js_util.callMethod(_hasOwnProperty, 'call', [o, name]);

4
tests/lib/analyzer/analyze_library.status
View file

@ -9,6 +9,7 @@ lib/_chrome/dart2js/chrome_dart2js: CompileTimeError # Issue 16522
lib/html/html_common/html_common_dart2js: CompileTimeError # Issue 16522 lib/html/html_common/html_common_dart2js: CompileTimeError # Issue 16522
lib/indexed_db/dart2js/indexed_db_dart2js: CompileTimeError # Issue 16522 lib/indexed_db/dart2js/indexed_db_dart2js: CompileTimeError # Issue 16522
lib/js/dart2js/js_dart2js: CompileTimeError # Issue 16522 lib/js/dart2js/js_dart2js: CompileTimeError # Issue 16522
lib/js_util/dart2js/js_util_dart2js: CompileTimeError # Issue 16522
lib/svg/dart2js/svg_dart2js: CompileTimeError # Issue 16522 lib/svg/dart2js/svg_dart2js: CompileTimeError # Issue 16522
lib/typed_data/dart2js/native_typed_data_dart2js: CompileTimeError # Issue 16522 lib/typed_data/dart2js/native_typed_data_dart2js: CompileTimeError # Issue 16522
lib/typed_data/dart2js/typed_data_dart2js: CompileTimeError # Issue 16522 lib/typed_data/dart2js/typed_data_dart2js: CompileTimeError # Issue 16522
@ -25,4 +26,5 @@ lib/indexed_db/dartium/indexed_db_dartium: StaticWarning # Issue 21647
lib/web_audio/dartium/web_audio_dartium: StaticWarning # Issue 21647 lib/web_audio/dartium/web_audio_dartium: StaticWarning # Issue 21647
lib/svg/dartium/svg_dartium: StaticWarning # Issue 21647 lib/svg/dartium/svg_dartium: StaticWarning # Issue 21647
lib/_blink/dartium/_blink_dartium: StaticWarning # Undefined Creates and Returns classes lib/_blink/dartium/_blink_dartium: StaticWarning # Undefined Creates and Returns classes
lib/js/dartium/js_dartium: StaticWarning # Undefined Creates and Returns classes lib/js/dartium/js_dartium: StaticWarning # Undefined Creates and Returns classes
lib/js_util/dartium/js_util_dartium: StaticWarning # Issue 21647