languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Always count non-core libs when tracking migration progress.

Browse source 
Now that they're farther along, there's little need to keep them
separate.

Change-Id: I3dedcf34b97cf5f0645fe429b357a459850d65d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135740
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
This commit is contained in:
Robert Nystrom 2020-02-13 23:05:29 +00:00 committed by commit-bot@chromium.org
parent 9e2d9ecd92
commit 40d544bc26
1 changed files with 0 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
tools/migration/bin/progress.dart
View file

@ -19,17 +19,6 @@ import 'package:migration/src/test_directories.dart';
// TODO(rnystrom): Update this with numbers from migrating some language tests.
const _linesPerDay = 24607;
const _includeNonCoreLibs = false;
const _nonCoreLibs = [
"lib_2/html/",
"lib_2/isolate/",
"lib_2/mirrors/",
"lib_2/profiler/",
"lib_2/wasm/",
"standalone_2/io/",
];
/// Some legacy files test behavior that doesn't apply to NNBD at all which
/// means they don't end up in the migrated directory but are done. We put this
/// comment in the *legacy* file to track that it has been migrated.
@ -57,10 +46,6 @@ void main(List<String> arguments) {
var migratedLines = 0;
for (var legacyPath in listFiles(dir)) {
if (!_includeNonCoreLibs && _nonCoreLibs.any(legacyPath.startsWith)) {
continue;
}
files++;
var sourceLines = readFileLines(legacyPath);
lines += sourceLines.length;