[Test tool] Remove -c dartkb configuration

Change-Id: I178f18484b853aa35248fa9f6252509ec0df6832
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169500
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>

pkg/smith/lib/configuration.dart

@@ -611,7 +611,6 @@ class Compiler extends NamedEnum {
   static const appJitk = Compiler._('app_jitk');
   static const dartk = Compiler._('dartk');
   static const dartkp = Compiler._('dartkp');
-  static const dartkb = Compiler._('dartkb');
   static const specParser = Compiler._('spec_parser');
   static const fasta = Compiler._('fasta');
 
@@ -627,7 +626,6 @@ class Compiler extends NamedEnum {
     appJitk,
     dartk,
     dartkp,
-    dartkb,
     specParser,
     fasta,
   ], key: (compiler) => (compiler as Compiler).name);
@@ -680,7 +678,6 @@ class Compiler extends NamedEnum {
         return const [Runtime.none];
       case Compiler.appJitk:
       case Compiler.dartk:
-      case Compiler.dartkb:
         return const [Runtime.vm, Runtime.selfCheck];
       case Compiler.dartkp:
         return const [Runtime.dartPrecompiled];
@@ -709,7 +706,6 @@ class Compiler extends NamedEnum {
         return Runtime.none;
       case Compiler.appJitk:
       case Compiler.dartk:
-      case Compiler.dartkb:
         return Runtime.vm;
       case Compiler.dartkp:
         return Runtime.dartPrecompiled;

pkg/test_runner/lib/src/compiler_configuration.dart

@@ -98,7 +98,6 @@ abstract class CompilerConfiguration {
         return AppJitCompilerConfiguration(configuration);
 
       case Compiler.dartk:
-      case Compiler.dartkb:
         if (configuration.architecture == Architecture.simarm ||
             configuration.architecture == Architecture.simarm64 ||
             configuration.system == System.android) {

pkg/test_runner/lib/src/configuration.dart

@@ -200,7 +200,6 @@ class TestConfiguration {
       Compiler.appJitk,
       Compiler.dartdevk,
       Compiler.dartk,
-      Compiler.dartkb,
       Compiler.dartkp,
       Compiler.fasta,
       Compiler.dart2js,

pkg/test_runner/lib/src/options.dart

@@ -106,8 +106,6 @@ dartdevk:             Compile to JavaScript using dartdevk.
 app_jitk:             Compile the Dart code into Kernel and then into an app
                       snapshot.
 dartk:                Compile the Dart code into Kernel before running test.
-dartkb:               Compile the Dart code into Kernel with bytecode before
-                      running test.
 dartkp:               Compile the Dart code into Kernel and then Kernel into
                       AOT snapshot before running the test.
 spec_parser:          Parse Dart code using the specification parser.

pkg/test_runner/lib/src/runtime_configuration.dart

@@ -251,9 +251,6 @@ class DartVmRuntimeConfiguration extends RuntimeConfiguration {
         break;
     }
 
-    if (_configuration.compiler == Compiler.dartkb) {
-      multiplier *= 4;
-    }
     if (mode.isDebug) {
       multiplier *= 2;
     }

pkg/test_runner/lib/src/test_configurations.dart

@@ -141,8 +141,7 @@ Future testConfigurations(List<TestConfiguration> configurations) async {
         if (key == 'co19_2' || key == 'co19') {
           testSuites.add(Co19TestSuite(configuration, key));
         } else if ((configuration.compiler == Compiler.none ||
-                configuration.compiler == Compiler.dartk ||
-                configuration.compiler == Compiler.dartkb) &&
+                configuration.compiler == Compiler.dartk) &&
             configuration.runtime == Runtime.vm &&
             key == 'vm') {
           // vm tests contain both cc tests (added here) and dart tests (added

pkg/test_runner/lib/src/test_suite.dart

@@ -889,7 +889,6 @@ class StandardTestSuite extends TestSuite {
     const compilers = [
       Compiler.none,
       Compiler.dartk,
-      Compiler.dartkb,
       Compiler.dartkp,
       Compiler.appJitk,
     ];

pkg/test_runner/lib/src/utils.dart

@@ -413,7 +413,6 @@ class TestUtils {
 
   static void deleteTempSnapshotDirectory(TestConfiguration configuration) {
     if (configuration.compiler == Compiler.dartk ||
-        configuration.compiler == Compiler.dartkb ||
         configuration.compiler == Compiler.dartkp) {
       var checked = configuration.isChecked ? '-checked' : '';
       var minified = configuration.isMinified ? '-minified' : '';

tools/bots/test_matrix.json

@@ -3253,7 +3253,7 @@
           ]
         },
         {
-          "name": "remove out directory to do a clean linux-x64-bytecode build",
+          "name": "remove out directory",
           "script": "tools/bots/try_benchmarks.sh",
           "arguments": [
             "clean"

tools/git_cl_try.sh

@@ -6,13 +6,6 @@ function git-cl-try-vm-jit-app {
      -b app-kernel-linux-product-x64-try                     \
      -b app-kernel-linux-release-x64-try
 }
-function git-cl-try-vm-jit-dartkb {
-  echo "git-cl-try-vm-jit-dartkb"
-  git cl try -B dart/try                                     \
-     -b vm-dartkb-linux-release-simarm64-try                 \
-     -b vm-dartkb-linux-release-x64-abi-try                  \
-     -b vm-dartkb-linux-release-x64-try
-}
 function git-cl-try-vm-jit-reload {
   echo "git-cl-try-vm-jit-reload"
   git cl try -B dart/try                                     \
@@ -85,7 +78,6 @@ function git-cl-try-vm-san {
 function git-cl-try-vm-all {
   echo "git-cl-try-vm-all"
   git-cl-try-vm-jit-app
-  git-cl-try-vm-jit-dartkb
   git-cl-try-vm-jit-reload
   git-cl-try-vm-jit-rest
   git-cl-try-vm-ffi