languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-06 14:59:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Migration: add a test case for #44118.

Browse source 
Bug: https://github.com/dart-lang/sdk/issues/44118
Change-Id: I9c62d8d90240458c8609a74a2cd49b703da0fb29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171240
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
This commit is contained in:
Paul Berry 2020-11-10 15:07:06 +00:00 committed by commit-bot@chromium.org
parent eb5fea9f3d
commit 3e5f021579
1 changed files with 33 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
pkg/nnbd_migration/test/migration_cli_test.dart
View file

@ -144,7 +144,8 @@ class _MigrationCliRunner extends MigrationCliRunner {
@override
Set<String> computePathsToProcess(DriverBasedAnalysisContext context) =>
cli._test.overridePathsToProcess ?? super.computePathsToProcess(context);
cli._test.overridePathsToProcess ??
_sortPaths(super.computePathsToProcess(context));
@override
NonNullableFix createNonNullableFix(
@ -185,6 +186,13 @@ class _MigrationCliRunner extends MigrationCliRunner {
bool shouldBeMigrated(DriverBasedAnalysisContext context, String path) =>
cli._test.overrideShouldBeMigrated?.call(path) ??
super.shouldBeMigrated(context, path);
/// Sorts the paths in [paths] for repeatability of migration tests.
Set<String> _sortPaths(Set<String> paths) {
var pathList = paths.toList();
pathList.sort();
return pathList.toSet();
}
}
abstract class _MigrationCliTestBase {
@ -806,6 +814,30 @@ int? f() => null
expect(output, isNot(contains('package:bar/bar.dart')));
}
@FailingTest(issue: 'https://github.com/dart-lang/sdk/issues/44118')
test_lifecycle_issue_44118() async {
var projectContents = simpleProject(sourceText: '''
int f() => null
''');
projectContents['lib/foo.dart'] = '''
import 'test.dart';
''';
var projectDir = createProjectDir(projectContents);
await assertRunFailure([projectDir]);
var output = logger.stdoutBuffer.toString();
expect(output, contains('1 analysis issue found'));
var sep = resourceProvider.pathContext.separator;
expect(
output,
contains("error • Expected to find ';' at lib${sep}test.dart:1:12 • "
'(expected_token)'));
expect(
output,
contains(
'analysis errors will result in erroneous migration suggestions'));
expect(output, contains('Please fix the analysis issues'));
}
test_lifecycle_no_preview() async {
var projectContents = simpleProject();
var projectDir = createProjectDir(projectContents);