languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 03:07:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

[vm] Canonicalize unboxed int constants

Browse source 
Constants should be canonicalized.

Split off https://dart-review.googlesource.com/c/sdk/+/284300.

TEST=Apparently not triggered by any current tests.
TEST=Triggered by CL mentioned above.

Change-Id: Icfa0728303d53dd61607addeab2d09552f30a296
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332686
Reviewed-by: Tess Strickland <sstrickl@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
This commit is contained in:
Daco Harkes 2023-10-30 16:42:37 +00:00 committed by Commit Queue
parent 991f1aa248
commit 3cab7a2ce5
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
runtime/vm/compiler/frontend/base_flow_graph_builder.cc
View file

@ -261,7 +261,7 @@ Fragment BaseFlowGraphBuilder::IntConstant(int64_t value) {
Fragment BaseFlowGraphBuilder::UnboxedIntConstant(
int64_t value,
Representation representation) {
const auto& obj = Integer::ZoneHandle(Z, Integer::New(value, Heap::kOld));
const auto& obj = Integer::ZoneHandle(Z, Integer::NewCanonical(value));
auto const constant = new (Z) UnboxedConstantInstr(obj, representation);
Push(constant);
return Fragment(constant);