languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-18 20:41:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use Future<void> when extract an async method that returns nothing.

Browse source 
R=brianwilkerson@google.com

Change-Id: Ic148974ba587310c475795caf8ed0c8565d96909
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182664
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This commit is contained in:
Konstantin Shcheglov 2021-02-03 22:25:39 +00:00 committed by commit-bot@chromium.org
parent 43e4536ebb
commit 3be5f7c356
3 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/analysis_server/lib/src/services/correction/util.dart
View file

@ -861,6 +861,10 @@ class CorrectionUtils {
}
}
if (type is VoidType) {
return 'void';
}
throw StateError('(${type.runtimeType}) $type');
}

3
pkg/analysis_server/lib/src/services/refactoring/extract_method.dart
View file

@ -762,7 +762,8 @@ class ExtractMethodRefactoringImpl extends RefactoringImpl
} else if (_returnType == null) {
variableType = null;
if (_hasAwait) {
returnType = _getTypeCode(typeProvider.futureDynamicType);
var futureVoid = typeProvider.futureType2(typeProvider.voidType);
returnType = _getTypeCode(futureVoid);
} else {
returnType = 'void';
}

2
pkg/analysis_server/test/services/refactoring/extract_method_test.dart
View file

@ -2431,7 +2431,7 @@ main() async {
// end
}
Future<dynamic> res() async {
Future<void> res() async {
int v = await getValue();
print(v);
}