languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 23:09:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

[dart2wasm] Remove unnecessary initializer list collectContexts call

Browse source 
The `collectContexts(member)` already visits initializer lists when
visiting constructors, so no need to call it separately for
initializers.

Change-Id: Ida51a0e8c4003f19cd7b533a2847946926237bc0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/317101
Commit-Queue: Ömer Ağacan <omersa@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
This commit is contained in:
Ömer Sinan Ağacan 2023-08-01 10:53:09 +00:00 committed by Commit Queue
parent a76f4d5c34
commit 39fe8f458a
2 changed files with 3 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
pkg/dart2wasm/lib/closures.dart
View file

@ -1037,10 +1037,9 @@ class Closures {
member.accept(find);
}
void collectContexts(TreeNode node, {TreeNode? container}) {
void collectContexts(TreeNode node) {
if (captures.isNotEmpty || isThisCaptured) {
node.accept(
ContextCollector(this, container, translator.options.enableAsserts));
node.accept(ContextCollector(this, translator.options.enableAsserts));
}
}
@ -1240,11 +1239,7 @@ class ContextCollector extends RecursiveVisitor {
Context? currentContext;
final bool enableAsserts;
ContextCollector(this.closures, TreeNode? container, this.enableAsserts) {
if (container != null) {
currentContext = closures.contexts[container]!;
}
}
ContextCollector(this.closures, this.enableAsserts);
@override
void visitAssertStatement(AssertStatement node) {

8
pkg/dart2wasm/lib/code_generator.dart
View file

@ -354,14 +354,6 @@ class CodeGenerator extends ExpressionVisitor1<w.ValueType, w.ValueType>
closures.findCaptures(member);
closures.collectContexts(member);
if (member is Constructor) {
for (Field field in member.enclosingClass.fields) {
if (field.isInstanceMember && field.initializer != null) {
closures.collectContexts(field.initializer!,
container: member.function);
}
}
}
closures.buildContexts();
allocateContext(member.function!);