From 391aa52fe4bfc465950ff2a064ee2d6869a798b7 Mon Sep 17 00:00:00 2001 From: Alexander Thomas Date: Tue, 26 May 2020 08:38:55 +0000 Subject: [PATCH] [test] Skip flaky canvasrendering tests in Chrome on Mac These tests alternative between Pass and RuntimeError, but somehow aren't detected as flaky automatically. https://github.com/dart-lang/sdk/issues/42048 Change-Id: Icb558f4f8e7c38baae0b8f3d721b69cad9db2c80 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149001 Commit-Queue: Alexander Thomas Commit-Queue: William Hesse Auto-Submit: Alexander Thomas Reviewed-by: William Hesse --- tests/lib/lib.status | 7 +++++-- tests/lib_2/lib_2.status | 7 +++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/tests/lib/lib.status b/tests/lib/lib.status index cd733a9ffa2..e005a493fd8 100644 --- a/tests/lib/lib.status +++ b/tests/lib/lib.status @@ -41,8 +41,11 @@ mirrors/native_class_test: Slow, Pass [ $runtime == chrome && $system == macos ] convert/streamed_conversion_utf8_encode_test: SkipSlow # Times out. Issue 22050 -html/canvasrenderingcontext2d_test/drawImage_video_element: Skip # Times out. Please triage this failure. -html/canvasrenderingcontext2d_test/drawImage_video_element_dataUrl: Skip # Times out. Please triage this failure. +html/canvasrendering/arc_test: Skip # Issue 42048 +html/canvasrendering/draw_image_canvas_element_test: Skip # Issue 42048 +html/canvasrendering/fill_text_test: Skip # Issue 42048 +html/canvasrendering/image_element_test: Skip # Issue 42048 +html/canvasrendering/pixel_manipulation_test: Skip # Issue 42048 html/request_animation_frame_test: Skip # Times out. Issue 22167 html/transition_event_test: Skip # Times out. Issue 22167 diff --git a/tests/lib_2/lib_2.status b/tests/lib_2/lib_2.status index 33653511897..c21cc4c2785 100644 --- a/tests/lib_2/lib_2.status +++ b/tests/lib_2/lib_2.status @@ -41,8 +41,11 @@ mirrors/native_class_test: Slow, Pass [ $runtime == chrome && $system == macos ] convert/streamed_conversion_utf8_encode_test: SkipSlow # Times out. Issue 22050 -html/canvasrenderingcontext2d_test/drawImage_video_element: Skip # Times out. Please triage this failure. -html/canvasrenderingcontext2d_test/drawImage_video_element_dataUrl: Skip # Times out. Please triage this failure. +html/canvasrendering/arc_test: Skip # Issue 42048 +html/canvasrendering/draw_image_canvas_element_test: Skip # Issue 42048 +html/canvasrendering/fill_text_test: Skip # Issue 42048 +html/canvasrendering/image_element_test: Skip # Issue 42048 +html/canvasrendering/pixel_manipulation_test: Skip # Issue 42048 html/request_animation_frame_test: Skip # Times out. Issue 22167 html/transition_event_test: Skip # Times out. Issue 22167