mirror of
https://github.com/dart-lang/sdk
synced 2024-09-19 15:01:29 +00:00
[ dart:developer ] Updated parentId argument for timeline events to use base64 to be consistent with async ID formatting
Change-Id: I96314f5712b722da5188c0a447a12c9c5fe6064b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120322 Reviewed-by: Kenzie Schmoll <kenzieschmoll@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com>
This commit is contained in:
parent
69b612beec
commit
38f78c01f3
|
@ -127,8 +127,10 @@ var tests = <VMTest>[
|
|||
eventsContains(dartEvents, 'i', 'ISYNC', {'fruit': 'banana'}), isTrue);
|
||||
expect(eventsContains(dartEvents, 'X', 'apple'), isTrue);
|
||||
expect(
|
||||
eventsContains(dartEvents, 'b', 'TASK1',
|
||||
{'task1-start-key': 'task1-start-value', 'parentId': 42}),
|
||||
eventsContains(dartEvents, 'b', 'TASK1', {
|
||||
'task1-start-key': 'task1-start-value',
|
||||
'parentId': 42.toRadixString(16)
|
||||
}),
|
||||
isTrue);
|
||||
expect(
|
||||
eventsContains(dartEvents, 'e', 'TASK1',
|
||||
|
|
|
@ -209,7 +209,7 @@ class TimelineTask {
|
|||
_stack.add(block);
|
||||
block._start({
|
||||
if (arguments != null) ...arguments,
|
||||
if (_parent != null) 'parentId': _parent._taskId,
|
||||
if (_parent != null) 'parentId': _parent._taskId.toRadixString(16),
|
||||
});
|
||||
}
|
||||
|
||||
|
|
|
@ -211,7 +211,7 @@ class TimelineTask {
|
|||
_stack.add(block);
|
||||
block._start({
|
||||
if (arguments != null) ...arguments,
|
||||
if (_parent != null) 'parentId': _parent._taskId,
|
||||
if (_parent != null) 'parentId': _parent._taskId.toRadixString(16),
|
||||
});
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue