languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-18 21:01:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ dart:developer ] Updated parentId argument for timeline events to use base64 to be consistent with async ID formatting

Browse source 
Change-Id: I96314f5712b722da5188c0a447a12c9c5fe6064b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120322
Reviewed-by: Kenzie Schmoll <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
This commit is contained in:
Ben Konyi 2019-10-04 23:27:22 +00:00 committed by commit-bot@chromium.org
parent 69b612beec
commit 38f78c01f3
3 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
runtime/observatory/tests/service/get_vm_timeline_rpc_test.dart
View file

@ -127,8 +127,10 @@ var tests = <VMTest>[
eventsContains(dartEvents, 'i', 'ISYNC', {'fruit': 'banana'}), isTrue);
expect(eventsContains(dartEvents, 'X', 'apple'), isTrue);
expect(
eventsContains(dartEvents, 'b', 'TASK1',
{'task1-start-key': 'task1-start-value', 'parentId': 42}),
eventsContains(dartEvents, 'b', 'TASK1', {
'task1-start-key': 'task1-start-value',
'parentId': 42.toRadixString(16)
}),
isTrue);
expect(
eventsContains(dartEvents, 'e', 'TASK1',

2
sdk/lib/developer/timeline.dart
View file

@ -209,7 +209,7 @@ class TimelineTask {
_stack.add(block);
block._start({
if (arguments != null) ...arguments,
if (_parent != null) 'parentId': _parent._taskId,
if (_parent != null) 'parentId': _parent._taskId.toRadixString(16),
});
}

2
sdk_nnbd/lib/developer/timeline.dart
View file

@ -211,7 +211,7 @@ class TimelineTask {
_stack.add(block);
block._start({
if (arguments != null) ...arguments,
if (_parent != null) 'parentId': _parent._taskId,
if (_parent != null) 'parentId': _parent._taskId.toRadixString(16),
});
}