mirror of
https://github.com/dart-lang/sdk
synced 2024-09-05 16:41:07 +00:00
[vm/ffi] Array range error message
Closes: https://github.com/dart-lang/sdk/issues/45189 Change-Id: I225a092fd05efe8a6eed7749375ea4c842547fb7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193404 Auto-Submit: Daco Harkes <dacoharkes@google.com> Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Siva Annamalai <asiva@google.com>
This commit is contained in:
parent
92c2fca87d
commit
38d5c5e444
|
@ -129,7 +129,7 @@ class Array<T extends NativeType> {
|
|||
|
||||
_checkIndex(int index) {
|
||||
if (index < 0 || index >= _size) {
|
||||
throw RangeError.range(index, 0, _size);
|
||||
throw RangeError.range(index, 0, _size - 1);
|
||||
}
|
||||
}
|
||||
|
||||
|
|
26
tests/ffi/regress_45189_test.dart
Normal file
26
tests/ffi/regress_45189_test.dart
Normal file
|
@ -0,0 +1,26 @@
|
|||
// Copyright (c) 2021, the Dart project authors. Please see the AUTHORS file
|
||||
// for details. All rights reserved. Use of this source code is governed by a
|
||||
// BSD-style license that can be found in the LICENSE file.
|
||||
|
||||
import "dart:ffi";
|
||||
|
||||
import "package:ffi/ffi.dart";
|
||||
import 'package:expect/expect.dart';
|
||||
|
||||
class Struct8BytesInlineArrayInt extends Struct {
|
||||
@Array(8)
|
||||
external Array<Uint8> a0;
|
||||
}
|
||||
|
||||
void main() {
|
||||
final pointer = calloc<Struct8BytesInlineArrayInt>();
|
||||
final array = pointer.ref.a0;
|
||||
try {
|
||||
array[8]; // RangeError: Invalid value: Not in inclusive range 0..8: 8
|
||||
} on RangeError catch (exception) {
|
||||
final toString = exception.toString();
|
||||
Expect.equals(
|
||||
"RangeError: Invalid value: Not in inclusive range 0..7: 8", toString);
|
||||
}
|
||||
calloc.free(pointer);
|
||||
}
|
26
tests/ffi_2/regress_45189_test.dart
Normal file
26
tests/ffi_2/regress_45189_test.dart
Normal file
|
@ -0,0 +1,26 @@
|
|||
// Copyright (c) 2021, the Dart project authors. Please see the AUTHORS file
|
||||
// for details. All rights reserved. Use of this source code is governed by a
|
||||
// BSD-style license that can be found in the LICENSE file.
|
||||
|
||||
import "dart:ffi";
|
||||
|
||||
import "package:ffi/ffi.dart";
|
||||
import 'package:expect/expect.dart';
|
||||
|
||||
class Struct8BytesInlineArrayInt extends Struct {
|
||||
@Array(8)
|
||||
Array<Uint8> a0;
|
||||
}
|
||||
|
||||
void main() {
|
||||
final pointer = calloc<Struct8BytesInlineArrayInt>();
|
||||
final array = pointer.ref.a0;
|
||||
try {
|
||||
array[8]; // RangeError: Invalid value: Not in inclusive range 0..8: 8
|
||||
} on RangeError catch (exception) {
|
||||
final toString = exception.toString();
|
||||
Expect.equals(
|
||||
"RangeError: Invalid value: Not in inclusive range 0..7: 8", toString);
|
||||
}
|
||||
calloc.free(pointer);
|
||||
}
|
Loading…
Reference in a new issue