From 385f3350c504a23fc46e09c206b6d6444448f620 Mon Sep 17 00:00:00 2001 From: Sigmund Cherem Date: Mon, 7 Mar 2016 10:20:41 -0800 Subject: [PATCH] Update status of cpsir tests in checked mode: skipping for now, since more than 75% fail for one reason, once we fix that we can triage in more detail. Review URL: https://codereview.chromium.org/1771893002 . --- pkg/pkg.status | 3 +++ runtime/tests/vm/vm.status | 3 +++ samples/samples.status | 4 ++++ tests/benchmark_smoke/benchmark_smoke.status | 3 +++ tests/co19/co19-dart2js.status | 3 +++ tests/compiler/dart2js_extra/dart2js_extra.status | 3 +++ tests/compiler/dart2js_native/dart2js_native.status | 3 +++ tests/html/html.status | 3 +++ tests/isolate/isolate.status | 3 +++ tests/language/language_dart2js.status | 3 +++ tests/standalone/standalone.status | 3 +++ 11 files changed, 34 insertions(+) diff --git a/pkg/pkg.status b/pkg/pkg.status index ab8dbf8b327..c44aaea7f2e 100644 --- a/pkg/pkg.status +++ b/pkg/pkg.status @@ -239,3 +239,6 @@ analyzer/test/src/task/yaml_test: Crash # Issue 24485 [ $noopt || $runtime == dart_precompiled || $runtime == dart_product ] *: SkipByDesign # The pkg test framework imports dart:mirrors. + +[ $compiler == dart2js && $cps_ir && $checked ] +*: Skip # `assert` not implemented, about 75% tests crash diff --git a/runtime/tests/vm/vm.status b/runtime/tests/vm/vm.status index eb62781f7b3..0a1fc8a1706 100644 --- a/runtime/tests/vm/vm.status +++ b/runtime/tests/vm/vm.status @@ -55,6 +55,9 @@ dart/optimized_stacktrace_test: RuntimeError # minifying they can be renamed, which is issue 7953. dart/inline_stack_frame_test: RuntimeError, Pass # Issue 7953 +[ $compiler == dart2js && $cps_ir && $checked ] +dart/inline_stack_frame_test: Crash # Unable to compile ArgumentError.message + [ $compiler == dart2js || $compiler == dart2analyzer ] # Data uri's not supported by dart2js or the analyzer. dart/data_uri*test: Skip diff --git a/samples/samples.status b/samples/samples.status index d9739f4497b..ac350139fb1 100644 --- a/samples/samples.status +++ b/samples/samples.status @@ -11,6 +11,10 @@ sample_extension: Skip [ $compiler == dart2js && $runtime == none ] *: Fail, Pass # TODO(ahe): Triage these tests. +[ $compiler == dart2js && $cps_ir && $checked ] +sample_extension: Crash # Unable to compile UnsupportedError.message. + + [ $compiler == dart2analyzer ] build_dart: Skip diff --git a/tests/benchmark_smoke/benchmark_smoke.status b/tests/benchmark_smoke/benchmark_smoke.status index 46f821f23f7..188684a35c6 100644 --- a/tests/benchmark_smoke/benchmark_smoke.status +++ b/tests/benchmark_smoke/benchmark_smoke.status @@ -8,3 +8,6 @@ [ $compiler == dart2js && $runtime == none ] *: Fail, Pass # TODO(ahe): Triage these tests. +[ $compiler == dart2js && $cps_ir && $checked ] +benchmark_smoke: Crash # `assert` not implemented + diff --git a/tests/co19/co19-dart2js.status b/tests/co19/co19-dart2js.status index 478f3c51adb..da9a0d1fdb9 100644 --- a/tests/co19/co19-dart2js.status +++ b/tests/co19/co19-dart2js.status @@ -9635,3 +9635,6 @@ LibTest/core/Invocation/memberName_A01_t01: RuntimeError # Expect.equals(expecte [ $compiler == dart2js && $cps_ir && $host_checked ] LayoutTests/fast/canvas/webgl/gl-uniformmatrix4fv_t01: Crash # CPS integrity violation After 'GVN' on function(main) Referenced out of scope: Instance of 'ReceiverCheck' + +[ $compiler == dart2js && $cps_ir && $checked ] +*: Skip # `assert` not implemented, about 75% tests crash diff --git a/tests/compiler/dart2js_extra/dart2js_extra.status b/tests/compiler/dart2js_extra/dart2js_extra.status index 1399e796804..2dfb1b6c87d 100644 --- a/tests/compiler/dart2js_extra/dart2js_extra.status +++ b/tests/compiler/dart2js_extra/dart2js_extra.status @@ -69,3 +69,6 @@ big_allocation_expression_test: Crash # Issue 24635 [ $compiler == dart2js && $cps_ir ] async_stacktrace_test/asyncStar: Crash # (foo()async*{try {tr... cannot handle sync*/async* functions + +[ $compiler == dart2js && $cps_ir && $checked ] +*: Skip # `assert` not implemented, 75% of the tests fail. diff --git a/tests/compiler/dart2js_native/dart2js_native.status b/tests/compiler/dart2js_native/dart2js_native.status index 3a172dedc06..e08d601e8bb 100644 --- a/tests/compiler/dart2js_native/dart2js_native.status +++ b/tests/compiler/dart2js_native/dart2js_native.status @@ -25,3 +25,6 @@ foreign_test: RuntimeError # Expect.equals(expected: <1234567891011>, actual: <1 native_exception_test: RuntimeError # Issue 24421 optimization_hints_test: RuntimeError # Please triage this failure. subclassing_constructor_2_test: RuntimeError # Please triage this failure. + +[ $compiler == dart2js && $cps_ir && $checked ] +*: Skip # `assert` not implemented, 75% of the tests fail. diff --git a/tests/html/html.status b/tests/html/html.status index e946676b14c..90fce45ab03 100644 --- a/tests/html/html.status +++ b/tests/html/html.status @@ -443,3 +443,6 @@ js_test/Dart_functions: RuntimeError # Tree-shaking an escaping closure #25720 js_typed_interop_default_arg_test/none: Crash # Issue 25911 js_typed_interop_default_arg_test/default_value: Crash # Issue 25911 js_typed_interop_default_arg_test/explicit_argument: Crash # Issue 25911 + +[ $compiler == dart2js && $cps_ir && $checked ] +*: Skip # `assert` not implemented diff --git a/tests/isolate/isolate.status b/tests/isolate/isolate.status index c2bcfaedbcc..3508c2c22e0 100644 --- a/tests/isolate/isolate.status +++ b/tests/isolate/isolate.status @@ -180,3 +180,6 @@ error_at_spawnuri_test: Skip # Isolate.spawnUri [ $runtime == dart_product ] spawn_uri_missing_from_isolate_test: Skip # SpawnUri in product mode spawn_uri_missing_test: Skip # SpawnUri in product mode + +[ $compiler == dart2js && $cps_ir && $checked ] +*: Skip # `assert` not implemented diff --git a/tests/language/language_dart2js.status b/tests/language/language_dart2js.status index 76f8d3e506d..1d68288af8a 100644 --- a/tests/language/language_dart2js.status +++ b/tests/language/language_dart2js.status @@ -317,3 +317,6 @@ execute_finally9_test: Crash # Issue 24485 regress_21795_test: Crash # Issue 24485 regress_23537_test: Crash # Issue 24485 try_finally_regress_25333_test: Crash # Issue 24485 + +[ $compiler == dart2js && $cps_ir && $checked ] +*: Skip # `assert` not implemented diff --git a/tests/standalone/standalone.status b/tests/standalone/standalone.status index 41f4d09544d..68ecd8b1765 100644 --- a/tests/standalone/standalone.status +++ b/tests/standalone/standalone.status @@ -109,6 +109,9 @@ precompilation_test: Skip # Standalone only test. precompilation_dart2js_test: Skip # Standalone only test. regress_25335_test: Skip # Int64List not supported. +[ $compiler == dart2js && $cps_ir && $checked ] +*: Skip # `assert` not implemented + [ ($runtime == vm || $runtime == dart_product) && $mode == debug ] precompilation_dart2js_test: Pass, Slow