languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-04 20:19:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix references to StaticWarningCodes which are now CompileTimeErrorCodes

Browse source 
Change-Id: I89390b6f89de4301460e092b8828d720ac9c3224
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217155
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
This commit is contained in:
Sam Rawlins 2021-10-19 04:54:50 +00:00 committed by commit-bot@chromium.org
parent 38b5a841de
commit 37b3ed798f
5 changed files with 26 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/analyzer/lib/src/dart/resolver/assignment_expression_resolver.dart
View file

@ -128,7 +128,7 @@ class AssignmentExpressionResolver {
/// when it returns 'void'. Or, in rare cases, when other types of expressions
/// are void, such as identifiers.
///
/// See [StaticWarningCode.USE_OF_VOID_RESULT].
/// See [CompileTimeErrorCode.USE_OF_VOID_RESULT].
/// TODO(scheglov) this is duplicate
bool _checkForUseOfVoidResult(Expression expression) {
if (!identical(expression.staticType, VoidTypeImpl.instance)) {

2
pkg/analyzer/lib/src/dart/resolver/function_expression_invocation_resolver.dart
View file

@ -84,7 +84,7 @@ class FunctionExpressionInvocationResolver {
/// when it returns 'void'. Or, in rare cases, when other types of expressions
/// are void, such as identifiers.
///
/// See [StaticWarningCode.USE_OF_VOID_RESULT].
/// See [CompileTimeErrorCode.USE_OF_VOID_RESULT].
///
/// TODO(scheglov) this is duplicate
bool _checkForUseOfVoidResult(Expression expression, DartType type) {

15
pkg/analyzer/lib/src/generated/error_detection_helpers.dart
View file

@ -51,7 +51,7 @@ mixin ErrorDetectionHelpers {
/// This method corresponds to
/// [BestPracticesVerifier.checkForArgumentTypeNotAssignableForArgument].
///
/// See [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE].
/// See [CompileTimeErrorCode.ARGUMENT_TYPE_NOT_ASSIGNABLE].
void checkForArgumentTypeNotAssignableForArgument(Expression argument,
{bool promoteParameterToNullable = false,
Map<DartType, NonPromotionReason> Function()? whyNotPromoted}) {
@ -68,7 +68,7 @@ mixin ErrorDetectionHelpers {
/// from the name in the [ConstructorFieldInitializer].
///
/// See [CompileTimeErrorCode.CONST_FIELD_INITIALIZER_NOT_ASSIGNABLE], and
/// [StaticWarningCode.FIELD_INITIALIZER_NOT_ASSIGNABLE].
/// [CompileTimeErrorCode.FIELD_INITIALIZER_NOT_ASSIGNABLE].
void checkForFieldInitializerNotAssignable(
ConstructorFieldInitializer initializer, FieldElement fieldElement,
{required bool isConstConstructor,
@ -169,7 +169,7 @@ mixin ErrorDetectionHelpers {
/// when it returns 'void'. Or, in rare cases, when other types of expressions
/// are void, such as identifiers.
///
/// See [StaticWarningCode.USE_OF_VOID_RESULT].
/// See [CompileTimeErrorCode.USE_OF_VOID_RESULT].
bool checkForUseOfVoidResult(Expression expression) {
if (!identical(expression.staticType, VoidTypeImpl.instance)) {
return false;
@ -265,13 +265,10 @@ mixin ErrorDetectionHelpers {
/// Verify that the given [expression] can be assigned to its corresponding
/// parameters.
///
/// See [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE],
/// See [CompileTimeErrorCode.ARGUMENT_TYPE_NOT_ASSIGNABLE],
/// [CompileTimeErrorCode.LIST_ELEMENT_TYPE_NOT_ASSIGNABLE],
/// [StaticWarningCode.LIST_ELEMENT_TYPE_NOT_ASSIGNABLE],
/// [CompileTimeErrorCode.MAP_KEY_TYPE_NOT_ASSIGNABLE],
/// [CompileTimeErrorCode.MAP_VALUE_TYPE_NOT_ASSIGNABLE],
/// [StaticWarningCode.MAP_KEY_TYPE_NOT_ASSIGNABLE], and
/// [StaticWarningCode.MAP_VALUE_TYPE_NOT_ASSIGNABLE].
/// [CompileTimeErrorCode.MAP_KEY_TYPE_NOT_ASSIGNABLE], and
/// [CompileTimeErrorCode.MAP_VALUE_TYPE_NOT_ASSIGNABLE].
void _checkForArgumentTypeNotAssignableWithExpectedTypes(
Expression expression,
DartType? expectedStaticType,

36
pkg/analyzer/lib/src/generated/error_verifier.dart
View file

@ -1507,9 +1507,9 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
/// Verify that the given [expression] is not final.
///
/// See [StaticWarningCode.ASSIGNMENT_TO_CONST],
/// [StaticWarningCode.ASSIGNMENT_TO_FINAL], and
/// [StaticWarningCode.ASSIGNMENT_TO_METHOD].
/// See [CompileTimeErrorCode.ASSIGNMENT_TO_CONST],
/// [CompileTimeErrorCode.ASSIGNMENT_TO_FINAL], and
/// [CompileTimeErrorCode.ASSIGNMENT_TO_METHOD].
void _checkForAssignmentToFinal(Expression expression) {
// TODO(scheglov) Check SimpleIdentifier(s) as all other nodes.
if (expression is! SimpleIdentifier) return;
@ -1650,7 +1650,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
/// Verify that the given [switchCase] is terminated with 'break', 'continue',
/// 'return' or 'throw'.
///
/// see [StaticWarningCode.CASE_BLOCK_NOT_TERMINATED].
/// see [CompileTimeErrorCode.CASE_BLOCK_NOT_TERMINATED].
void _checkForCaseBlockNotTerminated(SwitchCase switchCase) {
NodeList<Statement> statements = switchCase.statements;
if (statements.isEmpty) {
@ -1692,7 +1692,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
/// Verify that the switch cases in the given switch [statement] are
/// terminated with 'break', 'continue', 'rethrow', 'return' or 'throw'.
///
/// See [StaticWarningCode.CASE_BLOCK_NOT_TERMINATED].
/// See [CompileTimeErrorCode.CASE_BLOCK_NOT_TERMINATED].
void _checkForCaseBlocksNotTerminated(SwitchStatement statement) {
if (_isNonNullableByDefault) return;
@ -2432,7 +2432,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
/// variables if the list is final or const.
///
/// See [CompileTimeErrorCode.CONST_NOT_INITIALIZED], and
/// [StaticWarningCode.FINAL_NOT_INITIALIZED].
/// [CompileTimeErrorCode.FINAL_NOT_INITIALIZED].
void _checkForFinalNotInitialized(VariableDeclarationList list) {
if (_isInNativeClass || list.isSynthetic) {
return;
@ -2481,7 +2481,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
/// constructor are handled in [_checkForAllFinalInitializedErrorCodes].
///
/// See [CompileTimeErrorCode.CONST_NOT_INITIALIZED], and
/// [StaticWarningCode.FINAL_NOT_INITIALIZED].
/// [CompileTimeErrorCode.FINAL_NOT_INITIALIZED].
void _checkForFinalNotInitializedInClass(List<ClassMember> members) {
for (ClassMember classMember in members) {
if (classMember is ConstructorDeclaration) {
@ -2665,7 +2665,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
/// given [argument]. This is used for prefix and postfix expressions where
/// the argument value is implicit.
///
/// See [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE].
/// See [CompileTimeErrorCode.ARGUMENT_TYPE_NOT_ASSIGNABLE].
void _checkForIntNotAssignable(Expression argument) {
var staticParameterElement = argument.staticParameterElement;
var staticParameterType = staticParameterElement?.type;
@ -2839,8 +2839,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
/// Verify that the elements of the given list [literal] are subtypes of the
/// list's static type.
///
/// See [CompileTimeErrorCode.LIST_ELEMENT_TYPE_NOT_ASSIGNABLE], and
/// [StaticWarningCode.LIST_ELEMENT_TYPE_NOT_ASSIGNABLE].
/// See [CompileTimeErrorCode.LIST_ELEMENT_TYPE_NOT_ASSIGNABLE].
void _checkForListElementTypeNotAssignable(ListLiteral literal) {
// Determine the list's element type. We base this on the static type and
// not the literal's type arguments because in strong mode, the type
@ -3255,7 +3254,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
/// This method assumes that the instance creation was tested to be 'new'
/// before being called.
///
/// See [StaticWarningCode.NEW_WITH_UNDEFINED_CONSTRUCTOR].
/// See [CompileTimeErrorCode.NEW_WITH_UNDEFINED_CONSTRUCTOR].
void _checkForNewWithUndefinedConstructor(
InstanceCreationExpression expression,
ConstructorName constructorName,
@ -3400,7 +3399,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
/// Verify that the given method [declaration] of operator `[]=`, has `void`
/// return type.
///
/// See [StaticWarningCode.NON_VOID_RETURN_FOR_OPERATOR].
/// See [CompileTimeErrorCode.NON_VOID_RETURN_FOR_OPERATOR].
void _checkForNonVoidReturnTypeForOperator(MethodDeclaration declaration) {
// check that []= operator
SimpleIdentifier name = declaration.name;
@ -3421,7 +3420,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
/// Verify the [namedType], used as the return type of a setter, is valid
/// (either `null` or the type 'void').
///
/// See [StaticWarningCode.NON_VOID_RETURN_FOR_SETTER].
/// See [CompileTimeErrorCode.NON_VOID_RETURN_FOR_SETTER].
void _checkForNonVoidReturnTypeForSetter(TypeAnnotation? namedType) {
if (namedType != null) {
DartType type = namedType.typeOrThrow;
@ -3880,8 +3879,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
/// Verify that the elements in the given set [literal] are subtypes of the
/// set's static type.
///
/// See [CompileTimeErrorCode.SET_ELEMENT_TYPE_NOT_ASSIGNABLE], and
/// [StaticWarningCode.SET_ELEMENT_TYPE_NOT_ASSIGNABLE].
/// See [CompileTimeErrorCode.SET_ELEMENT_TYPE_NOT_ASSIGNABLE].
void _checkForSetElementTypeNotAssignable3(SetOrMapLiteral literal) {
// Determine the set's element type. We base this on the static type and
// not the literal's type arguments because in strong mode, the type
@ -3916,7 +3914,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
/// Check the given [typeReference] and that the [name] is not a reference to
/// an instance member.
///
/// See [StaticWarningCode.STATIC_ACCESS_TO_INSTANCE_MEMBER].
/// See [CompileTimeErrorCode.STATIC_ACCESS_TO_INSTANCE_MEMBER].
void _checkForStaticAccessToInstanceMember(
ClassElement? typeReference, SimpleIdentifier name) {
// OK, in comment
@ -3944,7 +3942,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
/// Check that the type of the expression in the given 'switch' [statement] is
/// assignable to the type of the 'case' members.
///
/// See [StaticWarningCode.SWITCH_EXPRESSION_NOT_ASSIGNABLE].
/// See [CompileTimeErrorCode.SWITCH_EXPRESSION_NOT_ASSIGNABLE].
void _checkForSwitchExpressionNotAssignable(SwitchStatement statement) {
// For NNBD we verify runtime types of values, and subtyping.
if (_isNonNullableByDefault) {
@ -4010,7 +4008,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
/// Verify that the [type] is not a deferred type.
///
/// See [StaticWarningCode.TYPE_ANNOTATION_DEFERRED_CLASS].
/// See [CompileTimeErrorCode.TYPE_ANNOTATION_DEFERRED_CLASS].
void _checkForTypeAnnotationDeferredClass(TypeAnnotation? type) {
if (type is NamedType && type.isDeferred) {
errorReporter.reportErrorForNode(
@ -4077,7 +4075,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
///
/// See [CompileTimeErrorCode.UNDEFINED_CONSTRUCTOR_IN_INITIALIZER_DEFAULT],
/// [CompileTimeErrorCode.NON_GENERATIVE_CONSTRUCTOR], and
/// [StaticWarningCode.NO_DEFAULT_SUPER_CONSTRUCTOR_EXPLICIT].
/// [CompileTimeErrorCode.NO_DEFAULT_SUPER_CONSTRUCTOR_EXPLICIT].
void _checkForUndefinedConstructorInInitializerImplicit(
ConstructorDeclaration constructor) {
if (_enclosingClass == null) {

5
pkg/analyzer/lib/src/generated/resolver.dart
View file

@ -451,10 +451,7 @@ class ResolverVisitor extends ResolverBase with ErrorDetectionHelpers {
/// Verify that the arguments in the given [argumentList] can be assigned to
/// their corresponding parameters.
///
/// This method corresponds to
/// [BestPracticesVerifier.checkForArgumentTypesNotAssignableInList].
///
/// See [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE].
/// See [CompileTimeErrorCode.ARGUMENT_TYPE_NOT_ASSIGNABLE].
void checkForArgumentTypesNotAssignableInList(ArgumentList argumentList,
List<WhyNotPromotedGetter> whyNotPromotedList) {
var arguments = argumentList.arguments;