languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[vm, gc] Remove dead path from promotion allocation.

Browse source 
The final TryAllocateDataLocked will consider all free list buckets and a new page. These cases are all covered by the preceding TryAllocateSmallLock (free list small buckets) and TryAllocateDataBumpLocked (free list large buckets and new pages), so this retry will always fail.

Change-Id: I9ba3174d588085130273ee6e7920888d3abca0ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135581
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
This commit is contained in:
Ryan Macnak 2020-02-14 17:41:37 +00:00 committed by commit-bot@chromium.org
parent f4bec13a15
commit 35705086c5
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
runtime/vm/heap/pages.cc
View file

@ -1336,9 +1336,7 @@ uword PageSpace::TryAllocatePromoLocked(intptr_t size) {
usage_.used_in_words = usage_.used_in_words + (size >> kWordSizeLog2);
return result;
}
result = TryAllocateDataBumpLocked(size);
if (result != 0) return result;
return TryAllocateDataLocked(size, PageSpace::kForceGrowth);
return TryAllocateDataBumpLocked(size);
}
void PageSpace::SetupImagePage(void* pointer, uword size, bool is_executable) {