languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 05:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

[tests/nnbd] Mark test as slow in debug mode, add diagnostics

Browse source 
Issue: https://github.com/dart-lang/sdk/issues/43613
Change-Id: I12fe82b3dc2eced6e0c582ecc487ef140e5edc40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165365
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
This commit is contained in:
Alexander Markov 2020-10-07 02:01:23 +00:00 committed by commit-bot@chromium.org
parent 2a649d3ef0
commit 34e8b4229e
3 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
runtime/tests/vm/vm.status
View file

@ -115,6 +115,7 @@ dart/minimal_kernel_bytecode_test: SkipSlow # gen_kernel is too slow in debug mo
dart/minimal_kernel_test: SkipSlow # gen_kernel is too slow in debug mode
dart/null_safety_autodetection_in_kernel_compiler_test: SkipSlow # gen_kernel is too slow in debug mode
dart/spawn_shutdown_test: Pass, Slow # VM Shutdown test, It can take some time for all the isolates to shutdown in a Debug build.
dart/type_casts_with_null_safety_autodetection_test: Pass, Slow # Very slow in debug mode, uses --optimization-counter-threshold=10
dart_2/appjit_cha_deopt_test: Pass, Slow # Quite slow in debug mode, uses --optimization-counter-threshold=100
dart_2/b162922506_test: SkipSlow # Generates very large input file
dart_2/minimal_kernel_bytecode_test: SkipSlow # gen_kernel is too slow in debug mode

4
tests/lib/isolate/detect_nullsafety_helper.dart
View file

@ -28,6 +28,8 @@ void generateOutput(String sourcePath, String outPath, String type) {
args.add("--enable-experiment=non-nullable");
args.add(sourcePath);
var result = Process.runSync(exec, args);
print('snapshot $type stdout: ${result.stdout}');
print('snapshot $type stderr: ${result.stderr}');
}
void generateKernel(String sourcePath, String outPath) {
@ -44,6 +46,8 @@ void testNullSafetyMode(String filePath, String expected) {
args.add("--enable-experiment=non-nullable");
args.add(filePath);
var result = Process.runSync(exec, args);
print('test stdout: ${result.stdout}');
print('test stderr: ${result.stderr}');
expect(result.stdout.contains('$expected'), true);
}

4
tests/lib/isolate/nnbd_spawn_autodetect_helper.dart
View file

@ -54,6 +54,8 @@ void generateOutput(String sourcePath, String outPath, String type) {
args.add("--enable-experiment=non-nullable");
args.add(sourcePath);
var result = Process.runSync(exec, args);
print('snapshot $type stdout: ${result.stdout}');
print('snapshot $type stderr: ${result.stderr}');
}
void generateKernel(String sourcePath, String outPath) {
@ -70,5 +72,7 @@ void testNullSafetyMode(String filePath, String expected) {
args.add("--enable-experiment=non-nullable");
args.add(filePath);
var result = Process.runSync(exec, args);
print('test stdout: ${result.stdout}');
print('test stderr: ${result.stderr}');
expect(result.stdout.contains('$expected'), true);
}