mirror of
https://github.com/dart-lang/sdk
synced 2024-09-15 21:20:36 +00:00
Changed error messages to report the URI of the offending file, rather than its "name".
Now you can actually find them. Review URL: https://chromereviews.googleplex.com/3569014 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@237 260f80e4-7a28-3924-810f-c04153c831b5
This commit is contained in:
parent
115edafe88
commit
340daa5ed0
|
@ -287,9 +287,9 @@ public class DartCompilationError {
|
|||
@Override
|
||||
public String toString() {
|
||||
StringBuilder sb = new StringBuilder();
|
||||
sb.append((source != null) ? source.getName() : "<unknown source>");
|
||||
sb.append((source != null) ? source.getUri() : "<unknown source>");
|
||||
sb.append("(" + lineNumber + ":" + columnNumber + "): ");
|
||||
sb.append(message);
|
||||
return sb.toString();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
@ -21,7 +21,7 @@ public class DefaultErrorFormatter implements ErrorFormatter {
|
|||
public void format(DartCompilationError event) {
|
||||
outputStream.printf("%s:%d:%d: %s\n",
|
||||
(event.getSource() != null)
|
||||
? event.getSource().getName() : "<unknown-source-file>",
|
||||
? event.getSource().getUri() : "<unknown-source-file>",
|
||||
event.getLineNumber(),
|
||||
event.getColumnNumber(),
|
||||
event.getMessage());
|
||||
|
|
|
@ -73,7 +73,7 @@ public class PrettyErrorFormatter extends DefaultErrorFormatter {
|
|||
StringBuilder buf = new StringBuilder();
|
||||
buf.append(String.format("%s%s:%d: %s%s\n",
|
||||
useColor ? RED_BOLD_COLOR : "",
|
||||
sourceFile.getName(),
|
||||
sourceFile.getUri(),
|
||||
event.getLineNumber(),
|
||||
event.getMessage(),
|
||||
useColor ? NO_COLOR : ""));
|
||||
|
|
|
@ -50,7 +50,7 @@ public class DartCompilerListenerTest extends DartCompilerListener {
|
|||
@Override
|
||||
public void compilationError(DartCompilationError event) {
|
||||
String reportedSrcName = (event.getSource() != null)
|
||||
? event.getSource().getName()
|
||||
? event.getSource().getUri().toString()
|
||||
: null;
|
||||
if (reportedSrcName == null) {
|
||||
reportedSrcName = "<unknown>";
|
||||
|
|
Loading…
Reference in a new issue