languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 11:31:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Shared analysis: update ifCaseElement API to match ifCase.

Browse source 
This change makes the API for the `ifCaseElement` method similar to
that of `ifCase`, which should make it easier to write flow analysis
unit tests for if-case elements.

Bug: https://github.com/dart-lang/sdk/issues/50419
Change-Id: I64c160f3b6df38b0d337f9b8f9c6c9189e9a13ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274161
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
This commit is contained in:
Paul Berry 2022-12-07 22:08:30 +00:00 committed by Commit Queue
parent 759a742c16
commit 3407cdb6ac
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/_fe_analyzer_shared/test/mini_ast.dart
View file

@ -220,9 +220,9 @@ Statement ifCase(Expression expression, PossiblyGuardedPattern pattern,
CollectionElement ifCaseElement(
Expression expression,
PossiblyGuardedPattern pattern,
CollectionElement ifTrue, {
CollectionElement ifTrue, [
CollectionElement? ifFalse,
}) {
]) {
var location = computeLocation();
var guardedPattern = pattern._asGuardedPattern;
return new _IfCaseElement(

2
pkg/_fe_analyzer_shared/test/type_inference/type_inference_test.dart
View file

@ -78,7 +78,7 @@ main() {
expr('Object'),
intLiteral(0).pattern,
intLiteral(1).checkContext('int').asCollectionElement,
ifFalse: intLiteral(2).checkContext('int').asCollectionElement,
intLiteral(2).checkContext('int').asCollectionElement,
)
.checkIr('if(expression: expr(Object), pattern: '
'const(0, matchedType: Object), guard: true, '