languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 00:09:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

[cfe] Remove special handling of _getMainClosure

Browse source 
Closes #28989

Change-Id: Ibaef1738702937274daa2ef0d1c4c19842e3804c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/300201
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
This commit is contained in:
Johnni Winther 2023-05-02 06:36:19 +00:00 committed by Commit Queue
parent b4c5f310d7
commit 33072da8d1
1 changed files with 0 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
pkg/front_end/lib/src/fasta/kernel/body_builder.dart
View file

@ -333,18 +333,6 @@ class BodyBuilder extends StackListenerImpl
final bool stringExpectedAfterNative;
/// Whether to ignore an unresolved reference to `main` within the body of
/// `_getMainClosure` when compiling the current library.
///
/// This as a temporary workaround. The standalone VM and flutter have
/// special logic to resolve `main` in `_getMainClosure`, this flag is used to
/// ignore that reference to `main`, but only on libraries where we expect to
/// see it (today that is dart:_builtin and dart:ui).
///
// TODO(ahe,sigmund): remove when the VM gets rid of the special rule, see
// https://github.com/dart-lang/sdk/issues/28989.
final bool ignoreMainInGetMainClosure;
// TODO(ahe): Consider renaming [uri] to 'partUri'.
@override
final Uri uri;
@ -527,10 +515,6 @@ class BodyBuilder extends StackListenerImpl
.enableNative(libraryBuilder.importUri),
stringExpectedAfterNative = libraryBuilder
.loader.target.backendTarget.nativeExtensionExpectsString,
ignoreMainInGetMainClosure =
libraryBuilder.importUri.isScheme('dart') &&
(libraryBuilder.importUri.path == "_builtin" ||
libraryBuilder.importUri.path == "ui"),
needsImplicitSuperInitializer =
context.needsImplicitSuperInitializer(coreTypes),
benchmarker = libraryBuilder.loader.target.benchmarker,
@ -3508,10 +3492,6 @@ class BodyBuilder extends StackListenerImpl
return new ThisPropertyAccessGenerator(this, token, n,
thisVariable: thisVariable);
}
} else if (ignoreMainInGetMainClosure &&
name == "main" &&
member.name == "_getMainClosure") {
return forest.createNullLiteral(charOffset);
} else {
return new UnresolvedNameGenerator(this, token, n,
unresolvedReadKind: UnresolvedKind.Unknown);