languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-19 20:51:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Partial cleanup towards fixing Issue 6726

Browse source 
(try to add all constants strings in the VM to the symbols list).
Review URL: https://codereview.chromium.org//11419261

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15618 260f80e4-7a28-3924-810f-c04153c831b5
This commit is contained in:
asiva@google.com 2012-12-01 00:34:19 +00:00
parent 5f4ad90c85
commit 311e4c8c19
3 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
runtime/vm/dart_api_impl.cc
View file

@ -1838,7 +1838,7 @@ DART_EXPORT Dart_Handle Dart_ListLength(Dart_Handle list, intptr_t* len) {
if (instance.IsNull()) {
return Api::NewError("Object does not implement the List interface");
}
String& name = String::Handle(isolate, String::New("length"));
String& name = String::Handle(isolate, Symbols::Length());
name = Field::GetterName(name);
const Function& function =
Function::Handle(isolate, Resolver::ResolveDynamic(instance, name, 1, 0));
@ -1904,7 +1904,7 @@ DART_EXPORT Dart_Handle Dart_ListGetAt(Dart_Handle list, intptr_t index) {
const Instance& instance =
Instance::Handle(isolate, GetListInstance(isolate, obj));
if (!instance.IsNull()) {
String& name = String::Handle(isolate, String::New("[]"));
String& name = String::Handle(isolate, Symbols::IndexToken());
const Function& function =
Function::Handle(isolate,
Resolver::ResolveDynamic(instance, name, 2, 0));
@ -1956,7 +1956,7 @@ DART_EXPORT Dart_Handle Dart_ListSetAt(Dart_Handle list,
const Instance& instance =
Instance::Handle(isolate, GetListInstance(isolate, obj));
if (!instance.IsNull()) {
String& name = String::Handle(isolate, String::New("[]="));
String& name = String::Handle(isolate, Symbols::AssignIndexToken());
const Function& function =
Function::Handle(isolate,
Resolver::ResolveDynamic(instance, name, 3, 0));
@ -2038,7 +2038,7 @@ DART_EXPORT Dart_Handle Dart_ListGetAsBytes(Dart_Handle list,
const Instance& instance =
Instance::Handle(isolate, GetListInstance(isolate, obj));
if (!instance.IsNull()) {
String& name = String::Handle(isolate, String::New("[]"));
String& name = String::Handle(isolate, Symbols::IndexToken());
const Function& function =
Function::Handle(isolate,
Resolver::ResolveDynamic(instance, name, 2, 0));
@ -2126,7 +2126,7 @@ DART_EXPORT Dart_Handle Dart_ListSetAsBytes(Dart_Handle list,
const Instance& instance =
Instance::Handle(isolate, GetListInstance(isolate, obj));
if (!instance.IsNull()) {
String& name = String::Handle(isolate, String::New("[]="));
String& name = String::Handle(isolate, Symbols::AssignIndexToken());
const Function& function =
Function::Handle(isolate,
Resolver::ResolveDynamic(instance, name, 3, 0));

2
runtime/vm/dart_entry.cc
View file

@ -302,7 +302,7 @@ RawObject* DartLibraryCalls::NewSendPort(intptr_t port_id) {
RawObject* DartLibraryCalls::MapSetAt(const Instance& map,
const Instance& key,
const Instance& value) {
String& name = String::Handle(String::New("[]="));
String& name = String::Handle(Symbols::AssignIndexToken());
const Function& function = Function::Handle(
Resolver::ResolveDynamic(map, name, 3, 0));
ASSERT(!function.IsNull());

1
runtime/vm/symbols.h
View file

@ -20,6 +20,7 @@ class ObjectPointerVisitor;
V(Equals, "=") \
V(EqualOperator, "==") \
V(Identical, "identical") \
V(Length, "length") \
V(IndexToken, "[]") \
V(AssignIndexToken, "[]=") \
V(TopLevel, "::") \